Closed Bug 1834569 Opened 1 year ago Closed 8 months ago

WebGPU CTS upstream should only require generating WPT tests once

Categories

(Core :: Graphics: WebGPU, defect, P2)

defect

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: ErichDonGubler, Assigned: ErichDonGubler)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We vendor in new CTS test cases using dom/webgpu/tests/cts/vendor. We currently have to work around gpuweb/cts#1092 by stealing some files from npm run standalone so that we can actually run the files generated by npm run wpt (see also this SearchFox permalink).

This bug tracks the resolution of the upstream issue, and migration we want/need to do after it's fixed.

Depends on: 1834558

This change will need to piggyback or, at the very least, come after a CTS update.

Assignee: nobody → egubler
Status: NEW → ASSIGNED

The severity field is not set for this bug.
:jimb, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jimb)

Now that we're consuming upstream changes in CTS (namely,
gpuweb/cts#1092), we need
not do this any more. Woot!

Depends on D181310

Attachment #9339661 - Attachment description: WIP: Bug 1834569: refactor(webgpu): stop stealing `out/` files from CTS codegen r?#webgpu-reviewers → Bug 1834569: refactor(webgpu): stop stealing `out/` files from CTS codegen r?#webgpu-reviewers

The review submission I've made here is ready to land (thanks for the review, :nical!), but only after we actually get CTS updated with bug 1834558. I believe the risk of the patch being invalidated is negligible, given the only purpose of this code is to update the CTS.

Severity: -- → S4
Flags: needinfo?(jimb)
Priority: -- → P2

Going to take this off my plate for now. I don't see this bug getting attended to any time soon, with the priorities the team currently has, but the patch here shouldn't change in the meantime.

Assignee: egubler → nobody
Status: ASSIGNED → NEW
Blocks: webgpu-phase-2
No longer blocks: webgpu-v1-cts-blockers
Assignee: nobody → egubler
Status: NEW → ASSIGNED
Pushed by egubler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf7c99fc0472
refactor(webgpu): stop stealing `out/` files from CTS codegen r=webgpu-reviewers,nical
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: