1834606 - In Unified Folders mode, Empty Junk folder on context menu throw error in console and cannot be emptied

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[[:Aureliano Buendía]]

In Unified Folders mode, Empty Junk folder has no effect. In console I see this error:

Uncaught NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgFolder.deleteMessages]
emptyJunk chrome://messenger/content/about3Pane.js:2346
onCommand chrome://messenger/content/about3Pane.js:506
handleEvent chrome://messenger/content/about3Pane.js:263
about3Pane.js:2346
emptyJunk chrome://messenger/content/about3Pane.js:2346
onCommand chrome://messenger/content/about3Pane.js:506
handleEvent chrome://messenger/content/about3Pane.js:263

It happens both TB 114.0b4 (64-bit) and Daily

Comment 1

[Alessandro Castellani [:aleca]]

This still happens for me only when emptying the junk in unified mode.
Ben, can you take a look?

Comment 2

[Alessandro Castellani [:aleca]]

Probably unrelated, but even if the trash is emptied the counter of unread messages is not refreshed.

Comment 3

[Magnus Melin [:mkmelin]]

This could be related to bug 1835358

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1834606 - Fix emptying the Unified junk folder. r=#thunderbird-reviewers

Two problems here:

• We're trying to empty a virtual folder instead of the folders it searches.
• Attempting to delete zero messages throws an error.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ab0b6cede71f
Fix emptying the Unified junk folder. r=john.bieling

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9337983 [details]
Bug 1834606 - Fix emptying the Unified junk folder. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta w/ wsmwk via Matrix.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/1ca352eb2a10