Closed Bug 1835028 Opened 7 months ago Closed 6 months ago

Make ntp stylelint warnings errors instead

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox115 --- wontfix
firefox116 --- fixed

People

(Reporter: Gijs, Assigned: aminomancer)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1835028 - Change newtab stylelint problem severity from warning to error. r?Gijs,Standard8
48 bytes, text/x-phabricator-request
Details | Review

Given the patches in bug 1832765 are ready to go it probably make sense to do this afterwards. But we should probably upgrade them now rather than later - so they make infra go orange when people break the linting rules.

Blocks: fxms-build

Gijs - I'll submit a patch if you didn't already start on this?

Assignee: nobody → shughes
Status: NEW → ASSIGNED
Pushed by shughes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff4d39ae40cb
Change newtab stylelint problem severity from warning to error. r=Gijs,Standard8
Severity: -- → N/A
Priority: -- → P1

https://hg.mozilla.org/mozilla-central/rev/ff4d39ae40cb

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

The patch landed in nightly and beta is affected.
:aminomancer, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(shughes)
status-firefox115: affected → wontfix
Flags: needinfo?(shughes)
You need to log in before you can comment on or make changes to this bug.