Closed
Bug 1835028
Opened 1 year ago
Closed 1 year ago
Make ntp stylelint warnings errors instead
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
RESOLVED
FIXED
116 Branch
People
(Reporter: Gijs, Assigned: aminomancer)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Given the patches in bug 1832765 are ready to go it probably make sense to do this afterwards. But we should probably upgrade them now rather than later - so they make infra go orange when people break the linting rules.
Assignee | ||
Updated•1 year ago
|
Blocks: fxms-build
Assignee | ||
Comment 1•1 year ago
|
||
Gijs - I'll submit a patch if you didn't already start on this?
Assignee: nobody → shughes
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•1 year ago
|
||
Pushed by shughes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff4d39ae40cb
Change newtab stylelint problem severity from warning to error. r=Gijs,Standard8
Updated•1 year ago
|
Severity: -- → N/A
Priority: -- → P1
Comment 4•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
Comment 5•1 year ago
|
||
The patch landed in nightly and beta is affected.
:aminomancer, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox115
towontfix
.
For more information, please visit BugBot documentation.
Flags: needinfo?(shughes)
Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(shughes)
You need to log in
before you can comment on or make changes to this bug.
Description
•