1835028 - Make ntp stylelint warnings errors instead

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[:Gijs (out for now; he/him)]

Given the patches in bug 1832765 are ready to go it probably make sense to do this afterwards. But we should probably upgrade them now rather than later - so they make infra go orange when people break the linting rules.

Comment 1

[Shane Hughes [:aminomancer]]

Gijs - I'll submit a patch if you didn't already start on this?

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1835028 - Change newtab stylelint problem severity from warning to error. r?Gijs,Standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff4d39ae40cb
Change newtab stylelint problem severity from warning to error. r=Gijs,Standard8

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ff4d39ae40cb

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:aminomancer, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.