1835361 - Translations panel does not receive keyboard focus when activated with Enter/Space

Status: VERIFIED FIXED

(Firefox :: Translations, defect, P2)

Description

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

Attachment: Keyboard focus position when the panel is opened.png

STR:

1. Ensure that Translations are activated via browser.translations.enable=true.
2. On a translatable website, navigate to the awesomebar. Press Tab once to move the focus to PiP control (if present) and then (if needed) use Right Arrow key to focus the Translate this page toggle
3. Press Space or Enter to open a Translations panel
4. When the panel is opened, locate the keyboard focus position

Expected:

1. The focus is moved to the panel and the gear image button (Manage translation settings) is focused

Actual:

1. The keyboard focus remains on the toggle button. Screen reader user may not be aware of the panel being opened (i.e. an NVDA screen reader on Windows does not announce anything)

Notes:

1. pressing Tab once or pressing Down Arrow key would move the focus to the panel, thus the panel could be reached by a keyboard-only user, but this is a workaround and not an expected behavior, thus an a11y-S3 severity
2. Good example: Identity panel toggle (View site information)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:ayeddi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1835361 - Pass keypress events to the translations openPopup to fix focus issue; r?nordzilla!

Comment 3

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1835361 - Drive by remove unneeded tabindex=0 attributes; r?nordzilla!

These were needed due to a bug in the button implementation that has
since been fixed. I don't have the bug number, but I received this
feedback in a review, but the other bug hadn't landed yet.

Depends on D180986

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84929281473b
Pass keypress events to the translations openPopup to fix focus issue; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/77e98ee54f42
Drive by remove unneeded tabindex=0 attributes; r=nordzilla

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/84929281473b
https://hg.mozilla.org/mozilla-central/rev/77e98ee54f42

Comment 6

[Anna Yeddi [:ayeddi] ⛔ Out of office until November 12 ⛔]

I confirmed the expected keyboard behavior with and without screen reader running on macOS and Windows OS - the bug is fixed. Thanks a lot, Greg!