1835398 - Translations panel toggle does not communicate its collapsed/expanded state

Status: RESOLVED INVALID

(Firefox :: Translations, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Translations panel toggle button does not announce its expanded state.png

STR:

1. Ensure a screen reader is running
2. Ensure that Translations are activated via browser.translations.enable=true.
3. On a translatable website, navigate to the awesomebar. Press Tab once to move the focus to PiP control (if present) and then (if needed) use Right Arrow key to focus the Translate this page toggle
4. Observe a screen reader announcement
5. Press Space or Enter to open a Translations panel
6. Observe a screen reader announcement
7. (While the bug 1835361 is not resolved) move the focus away from the toggle and back by pressing Shift + Tab and then Tab
8. Observe a screen reader announcement
9. Press Escape to dismiss the panel
10. Focus the toggle button and observe a screen reader announcement

Expected:

1. The Translate this page button would, by default, when the panel is not visible, announce collapsed as its state and when opened the state would dynamically change to expanded and back to collapsed, when the panel is dismissed

Actual:

1. Screen reader is not announcing if the toggle button Translate this page has a popup panel attached or not (collapsed state would imply this to a user), and whether the panel itself is visible or not (expanded/collapsed states)

Notes:

1. Use aria-expanded set to false by default on the button element and update its value appropriately

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:nordzilla, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Greg Tatum [:gregtatum]]

I'm confused by this bug because other panels do not have this behavior from what I can tell. I do not see other panels reporting their collapsed state. I also can't see how to get the macOS VoiceOver to focus on the button after opening the panel, so this would mean the expanded state would never be reported. Is this bug correct :ayeddi? Can you provide other examples of panels with this behavior that I can reference?

I tried to reproduce with the bookmarks button, and the site protections panel, and they do not add this aria-expanded label or report collapsed state.

Comment 3

[Anna Yeddi [:ayeddi]]

(In reply to Greg Tatum [:gregtatum] from comment #2)

I'm confused by this bug because other panels do not have this behavior from what I can tell. I do not see other panels reporting their collapsed state. I also can't see how to get the macOS VoiceOver to focus on the button after opening the panel, so this would mean the expanded state would never be reported. Is this bug correct :ayeddi? Can you provide other examples of panels with this behavior that I can reference?

I tried to reproduce with the bookmarks button, and the site protections panel, and they do not add this aria-expanded label or report collapsed state.

Apologies, Greg, I should've clarified it while filing the bug. Since/when bug 1835361 is resolved and the focus is moved from the button on the toolbar to the panel itself, this should not be needed. It's if the focus stays on the toggle button, then we need to explicitly notify a user that there is new content that was opened (and they need to go to it to review). I can close this ticket when the keyboard focus patch is landed and tested/verified.

Comment 4

[Greg Tatum [:gregtatum]]

:ayeddi Did you want to verify the fix here before I close it?

Comment 5

[Anna Yeddi [:ayeddi]]

Thank you, :gregtatum, for working on this bug and bug 1835361 - the issue is confirmed fixed, feel free to close this bug.