1835367 - Translations panel includes a Translate to combobox that misses programmatic label

Status: VERIFIED FIXED

(Firefox :: Translations, defect, P2)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Combobox and its on-screen label are not related.png

STR:

1. Ensure a screen reader is running
2. Ensure Translations are activated via browser.translations.enable=true
3. On a translatable website, navigate to the awesomebar. Press Tab once to move the focus to PiP control (if present) and then (if needed) use Right Arrow key to focus the Translate this page toggle
4. Press Space or Enter to open a Translations panel. Until the bug 1835361 is not resolved, press Tab to move the focus to the Translations settings button
5. Press Tab once again to move the focus to the combobox with available language options.
6. Observe the announcement that a screen reader makes

Expected:

1. The combobox is announced its visual label (Translate to) as well as the preselected option: Translate to, {English}

Actual:

1. The combobox is only announcing its preselected option, while ignoring its on-screen label (Translate to) and only mentions the language: {English}

Comment 1

[Anna Yeddi [:ayeddi]]

Setting the accessibility severity as [access-s2] because in this case the lack of the label in an accessible name may confuse a user if this is a source language or if this is a target language that is currently selected, especially when a source language of the website is not clear or known by a user.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:nordzilla, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1835367 - Include programmatic label for the translate from/to menulist; r?nordzilla!

This changes the spoken on macOS VoiceOVer:

from: "Spanish, collapsed, pop up button"
to: "Spanish, Translate from, collapsed, pop up button"

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed276c5baa5e
Include programmatic label for the translate from/to menulist; r=nordzilla

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ed276c5baa5e

Comment 6

[Anna Yeddi [:ayeddi]]

Both comboboxes are announced with their on-screen labels now. Thank you for patching it, Greg!