1835470 - [win7 only] Display Attachments Inline option in the Menu bar is STILL misaligned on Windows 7

Status: RESOLVED WONTFIX

(Thunderbird :: Mail Window Front End, defect)

Description

[aoia7rz7l]

Tested on 102.11.0esr. This was supposedly fixed in bug 1827070 but AFAICT it is still affecting Windows 7.

STR:

1. Press the Alt key to force Thunderbird to show the Menu bar.
2. Select View.

Expected Behavior:

All options under View were properly aligned.

Actual Behavior:

The Display Attachments Inline option in the Menu bar is misaligned. The same option is not misaligned when accessed from the AppMenu.

This is actually not limited to the Display Attachments Inline option. For example the Events and Tasks > Find Events option is also misaligned in the same way. Interesting, this does not seem to affect options inside a submenu e.g. View > Message Body as > Original HTML/Simple HTML/Plain Text.

Re-running mozregression inside Windows 7 returned

Last good revision: a5f6ce11868f4a991b290bd411de007901f3bd93
First bad revision: 6236676f41d4ecb5a35da4bbef6d3018c7b2bee9
Pushlog : https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a5f6ce11868f4a991b290bd411de007901f3bd93&tochange=6236676f41d4ecb5a35da4bbef6d3018c7b2bee9
Switching bisection method to taskcluster
Getting comm-central builds between a5f6ce11868f4a991b290bd411de007901f3bd93 and 6236676f41d4ecb5a35da4bbef6d3018c7b2bee9
...
There are no build artifacts for these changesets (they are probably too old).

so essentially the same regression range in bug 1827070.

I doubled-checked this on a Windows 10 VM and it looked like this was not reproducible in 102.0a1 on Windows 10, which explained why the dev seemed to take no interest in fixing the issue.

Speculatively running mozregression --find-fix --bad 102 --good 114 on Windows 7 got me

First good revision: e81e0f3d337acadd38f28ed18a574c4f87077672
Last bad revision: 64e7f8df13e40da9190436c1203850d4ace79aef
Pushlog : https://hg.mozilla.org/comm-central/pushloghtml?fromchange=64e7f8df13e40da9190436c1203850d4ace79aef&tochange=e81e0f3d337acadd38f28ed18a574c4f87077672

although to be honest this is just because someone upped the padding again in preparation for another UI overhaul.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1835470-win-menu-alignment.patch

This is the patch from bug 1831159 rebased for 102.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9336356 [details] [diff] [review]
1835470-win-menu-alignment.patch

Thanks for taking care of this but unfortunately we're a few months away from end of life for 102 and we don't do uplift fixes for it unless they're related to dataloss or security.

Comment 3

[Alessandro Castellani [:aleca]]

WONTFIX as per comment 2.