1835852 - [US][nike.com] The State field is not captured in the Address Save/Update doorhanger

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: 2023-05-30_14h36_19.mp4

Found in

• Nightly 115.0a1 (2023-05-30)

Affected versions

• Nightly 115.0a1 (2023-05-30)

Tested platforms

• Affected platforms: Windows 10

Preconditions

• browser.search.region to US
• extensions.formautofill.addresses.capture.v2.enabled = true

Steps to reproduce

1. Reach the address form on https://www.nike.com
2. Fill in manually new Address info and submit the form

Expected result

• The complete address should be captured and stored with all the available info.

Actual result

• The State field (dropdown) is not captured in the Address save doorhanger and not saved in the Address manager.

Regression range

• N/A

Additional notes

• The State field that is not captured in the save doorhanger is also NOT autofilled.

• Not reproducible in Chrome, the State is captured in the save doorhanger and saved.

• Fathom Fox Sample: https://drive.google.com/file/d/1nDI5tqC4RP1iKMFb1RJj4UGl9YQn_k8P/view?usp=share_link

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:ailea, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Dimi Lee [:dimi]]

This issue should be fixed by Bug 1836468

Comment 3

[Alin Ilea, Desktop Test Engineering]

Attachment: 2023-07-19_16h44_36.mp4

Unfortunately, I am still able to reproduce the issue in the latest Nightly build 117.0a1. The State field is still not captured in the Address save doorhanger and it is not saved in the Address Manager.

Comment 4

[Dimi Lee [:dimi]]

Attachment: State <select> field runs checkVisibility.png

Hi emilio,
In credit card/address autofill, when we run our heuristic to determine the type of a <input> or <select> field, we use checkVisibility API first to filter out elements that are invisible[1].
However, when running checkVisibility on the State field of the address form in nike.com, the API returns false. Could you help check whether this is expected? Thank you!

[1] https://searchfox.org/mozilla-central/rev/8d43262674d6c6d469b821cca579b1240ebb42a5/toolkit/components/formautofill/shared/FormAutofillUtils.sys.mjs#440-448

Comment 5

[Emilio Cobos Álvarez (:emilio)]

It is invisible, right?

.css-1jjxzuj select {
  width: 100%;
  box-sizing: border-box;
  border-radius: var(--podium-cds-size-border-radius-s);
  outline: 0px;
  appearance: none;
  opacity: 0;
}

(In particular the opacity: 0)

It's just overlaid over the content.

Comment 6

[Dimi Lee [:dimi]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

It is invisible, right?

indeed, thank you for checking!

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1833618

Comment 8

[Janika Neuberger [:janika]]

This is fixed by Bug 1847687, because we now check a field's focusability instead of visibility when considering it for filling or capturing.

Comment 9

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in the latest Nightly 120.0a1 (2023-10-19).