1847687 - Consider using isFocusable instead of isVisible when determing whether a field is eligible for address and credit card autofill

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P3)

Description

[Dimi Lee [:dimi]]

We have seen in some cases, a field is not visible but should still be autofilled (state field in Bug 1835852, expiry month/year in Bug 1845321).

Maybe we should use "isFocusable" instead of "isVisible"? If this is the right thing to do, can we use elementIsFocusable[1]?

[1] https://searchfox.org/mozilla-central/rev/e4d8451468be3a0f8a9faa3d37cadf07200821ec/dom/interfaces/base/nsIFocusManager.idl#171

Comment 1

[Dimi Lee [:dimi]]

Maybe we should use "isFocusable" instead of "isVisible"? If this is the right thing to do, can we use elementIsFocusable[1]?

@edgar, we had chatted about this during the AllHands, but could you help confirm again that elementIsFocusable is the right API to use for our use cases, thank you!

Comment 2

[Edgar Chen [:edgar]]

Yes, you can use elementIsFocusable with flag=0 to check whether a element is focusable, i.e. does the focus can be moved to a element either by mouse clicking or calling element.focus(). And if I read code correctly, you can also use FLAG_BYMOUSE to check whether a element is focusable by mouse clicking.

Comment 3

[Janika Neuberger [:janika]]

Attachment: Bug 1847687 - Enable checking a credit card or address field's focusability by calling Services.focus.elementIsFocusable before autofilling - r?#credential-management-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8370540453d9
Enable checking a credit card or address field's focusability by calling Services.focus.elementIsFocusable before autofilling - r=credential-management-reviewers,dimi

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_HomeDepot.js

Backout link

Push with failures

Failure log

Comment 6

[Janika Neuberger [:janika]]

Hi @Norisz, thank you for pinging me! I checked the failures and updated and fixed the patch (see try push).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e7e8bd8a196
Enable checking a credit card or address field's focusability by calling Services.focus.elementIsFocusable before autofilling - r=credential-management-reviewers,dimi

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9e7e8bd8a196