1836294 - High freq OS X debug TEST-UNEXPECTED-FAIL | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_show_migration_wizard.js | leaked 2 window(s) until shutdown when Gecko 115 merges to Beta on 2023-06-05

Status: RESOLVED WONTFIX

(Firefox :: Messaging System, defect, P1)

Description

[Narcis Beleuzu [:NarcisB]]

[Tracking Requested - why for this release]:

Central-as-beta-simulation
How to run these simulations
Failure log

[task 2023-06-01T12:25:52.134Z] 12:25:52     INFO - GECKO(4869) | [Utility 4872, Main Thread] WARNING: IPC message 'PUtilityProcess::Msg_FOGData' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:507
[task 2023-06-01T12:25:52.135Z] 12:25:52     INFO - GECKO(4869) | [Utility 4872, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/checkouts/gecko/widget/cocoa/nsAppShell.mm:861
[task 2023-06-01T12:25:52.138Z] 12:25:52     INFO - GECKO(4869) | [Utility 4872, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4687
[task 2023-06-01T12:25:52.139Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/checkouts/gecko/widget/cocoa/nsAppShell.mm:861
[task 2023-06-01T12:25:52.691Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869, Main Thread] WARNING: '!top', file /builds/worker/checkouts/gecko/dom/xul/MenuBarListener.cpp:99
[task 2023-06-01T12:25:52.692Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869, Main Thread] WARNING: '!top', file /builds/worker/checkouts/gecko/dom/xul/MenuBarListener.cpp:99
[task 2023-06-01T12:25:52.812Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (1383d0800) [pid = 4869] [serial = 4] [outer = 0] [url = about:blank]
[task 2023-06-01T12:25:52.813Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (10ac1e010) [pid = 4869] [serial = 3] [outer = 0] [url = chrome://browser/content/browser.xhtml]
[task 2023-06-01T12:25:52.813Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (138e714e0) [pid = 4869] [serial = 10] [outer = 0] [url = chrome://mochikit/content/browser-harness.xhtml]
[task 2023-06-01T12:25:52.814Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (143793400) [pid = 4869] [serial = 11] [outer = 0] [url = about:blank]
[task 2023-06-01T12:25:52.814Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (12f0aac00) [pid = 4869] [serial = 39] [outer = 0] [url = about:blank]
[task 2023-06-01T12:25:52.815Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (135f9e400) [pid = 4869] [serial = 2] [outer = 0] [url = about:blank]
[task 2023-06-01T12:25:52.815Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (10ac1fd20) [pid = 4869] [serial = 1] [outer = 0] [url = chrome://browser/content/hiddenWindowMac.xhtml]
[task 2023-06-01T12:25:52.816Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (135c419c0) [pid = 4869] [serial = 5] [outer = 0] [url = chrome://extensions/content/dummy.xhtml]
[task 2023-06-01T12:25:52.816Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (144682560) [pid = 4869] [serial = 34] [outer = 0] [url = chrome://browser/content/migration/migration.xhtml]
[task 2023-06-01T12:25:52.817Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (13ae1b400) [pid = 4869] [serial = 7] [outer = 0] [url = chrome://extensions/content/dummy.xhtml]
[task 2023-06-01T12:25:52.817Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (14341b000) [pid = 4869] [serial = 35] [outer = 0] [url = about:blank]
[task 2023-06-01T12:25:52.817Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (13b4a4010) [pid = 4869] [serial = 36] [outer = 0] [url = chrome://browser/content/migration/migration.xhtml]
[task 2023-06-01T12:25:52.818Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (13b2f94e0) [pid = 4869] [serial = 8] [outer = 0] [url = about:blank]
[task 2023-06-01T12:25:52.818Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (14fab8000) [pid = 4869] [serial = 37] [outer = 0] [url = about:blank]
[task 2023-06-01T12:25:52.844Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3426
[task 2023-06-01T12:25:52.857Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869, Main Thread] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/worker/workspace/obj-build/dist/include/mozilla/Preferences.h:129
[task 2023-06-01T12:25:52.875Z] 12:25:52     INFO - GECKO(4869) | [Parent 4869, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4687
[task 2023-06-01T12:25:52.895Z] 12:25:52     INFO - TEST-INFO | Main app process: exit 0
[task 2023-06-01T12:25:52.895Z] 12:25:52     INFO - TEST-INFO | Confirming we saw 69 DOCSHELL created and 69 destroyed log strings.
[task 2023-06-01T12:25:52.896Z] 12:25:52     INFO - TEST-INFO | Confirming we saw 168 DOMWINDOW created and 168 destroyed log strings.
[task 2023-06-01T12:25:52.896Z] 12:25:52    ERROR - TEST-UNEXPECTED-FAIL | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_show_migration_wizard.js | leaked 2 window(s) until shutdown [url = chrome://browser/content/migration/migration.xhtml]
[task 2023-06-01T12:25:52.897Z] 12:25:52    ERROR - TEST-UNEXPECTED-FAIL | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_show_migration_wizard.js | leaked 2 window(s) until shutdown [url = about:blank]
[task 2023-06-01T12:25:52.897Z] 12:25:52     INFO - TEST-INFO | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_show_migration_wizard.js | windows(s) leaked: [pid = 4869] [serial = 34], [pid = 4869] [serial = 35], [pid = 4869] [serial = 36], [pid = 4869] [serial = 37]
[task 2023-06-01T12:25:52.898Z] 12:25:52    ERROR - TEST-UNEXPECTED-FAIL | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_show_migration_wizard.js | leaked 2 docShell(s) until shutdown
[task 2023-06-01T12:25:52.898Z] 12:25:52     INFO - TEST-INFO | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_show_migration_wizard.js | docShell(s) leaked: [pid = 4869] [id = 15], [pid = 4869] [id = 16]
[task 2023-06-01T12:25:52.899Z] 12:25:52     INFO - TEST-INFO | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_show_migration_wizard.js | This test created 0 hidden window(s)
[task 2023-06-01T12:25:52.899Z] 12:25:52     INFO - TEST-INFO | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_show_migration_wizard.js | This test created 1 hidden docshell(s)
[task 2023-06-01T12:25:52.900Z] 12:25:52     INFO - TEST-INFO | toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_click_element.js | This test created 0 hidden window(s)

Comment 1

[Donal Meehan [:dmeehan]]

:kpatenio in terms of timing, reminder 115 goes to beta next week https://whattrainisitnow.com/release/?version=115

Comment 2

[kpatenio]

Attachment: Bug 1836294 - try to fix perma-failure in browser_sma_show_migration_wizard.js

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e5bbd7d746b
try to fix perma-failure in browser_sma_show_migration_wizard.js r=mconley

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9e5bbd7d746b

Comment 5

[Serban Stanca [:SerbanS]]

The patch seems not to have solved the problem completely, now it's high frequency, as it can be seen in today's central as beta simulation.

Comment 6

[Cosmin Sabou [:CosminS]]

Seems to be OS X debug only: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel&revision=abc4bde2cbe28bda97679a37e8f57bad98835913&searchStr=bc&test_paths=toolkit%2Fcomponents%2Fmessaging-system%2Fschemas%2Fspecialmessageactionschemas%2Ftest%2Fbrowser%2Fbrowser.ini&selectedTaskRun=M5IP1t1OSnaYA4sWYjLoeg.0

Comment 7

[Intermittent Failures Robot]

1 failures in 3471 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1836294&startday=2023-05-29&endday=2023-06-04&tree=all

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1834115

Comment 9

[Donal Meehan [:dmeehan]]

Removing tracking + and setting 115 to fix-optional.
When the high-frequency issue is investigated and if the patch is considered safe, then we would still accept an uplift request for review

Comment 10

[kpatenio]

I can't reproduce the issue locally as a beta simulation. And reverting some conversions for modules used during the test from the regressing bug did not fix the error in try pushes (might be intermittent - here's an example push; has various commits). However, I was able to ascertain the following:

• the error occurs for the legacy migration wizard. As seen in the logs, the leak is coming from migration.xhtml and a blank page
• the pref browser.migrate.content-modal.enabled determines which migration wizard to use, even when we close the wizard; false is for the old one, or true for the new one
• when the regressing patch first landed, the pref was disabled for early and late beta, which aligns with the reported errors because we were showing the legacy wizard then. But, we recently fixed Bug 1837009, which sets the pref to true as default and ride the trains. We now have the pref as true.

I ran two try pushes comparing before and after fixing Bug 1837009 (also as beta simulation):

• before: https://treeherder.mozilla.org/jobs?repo=try&revision=b42aea0dbeb35c5b7b241a3317afc4b9093ed0a5
• after: https://treeherder.mozilla.org/jobs?repo=try&revision=cdade8d82036c309ca68812882854b61bd5fda5c

Seems like the transition to the new migration wizard "fixed" the issue. However, I still haven't determined why the leak happens and don't know what our plans are for the legacy wizard. @mconley - are we planning to remove the legacy wizard sometime soon?

Comment 11

[Mike Conley (:mconley) (:⚙️)]

are we planning to remove the legacy wizard sometime soon?

Yes, once we've rolled it out to everybody, and it's being used in all conditions (including startup migration / profile reset), I think we're safe to remove the old one!

Comment 12

[Intermittent Failures Robot]

1 failures in 3885 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1836294&startday=2023-06-05&endday=2023-06-11&tree=all

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:lsmith, could you have a look please?

For more information, please visit BugBot documentation.

Comment 14

[kpatenio]

Removing myself as assignee for the following reasons:

• currently, I have limited cycles
• I predict that once the new migration wizard is rolled out, the issue shouldn't occur anymore