18364 - [I18n] use string bundles for #defined strings in mozilla/mailnews/base

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

I'll do this after I move the migration code out of that file.

cc'ing bienvenu, the string bundle master.

Comment 1

[(not reading, please use [e-mail] instead)]

marking m13, accepting.

Comment 2

[(not reading, please use [e-mail] instead)]

i18n issues move to m14.

Comment 3

[(not reading, please use [e-mail] instead)]

marking p2

Comment 4

[(not reading, please use [e-mail] instead)]

move to m15

Comment 5

[(not reading, please use [e-mail] instead)]

this covers hard coded string in nsMsgAccountManager, nsMsgProtocol, and more.

Comment 6

[lchiang]

bulk move to M16. Not an M15 stopper.  If you disagree, pls comment in bug and 
cc: [e-mail]

Comment 7

[(not reading, please use [e-mail] instead)]

adding bobj.  these i18n bugs affect bob and his team.

Comment 8

[bobj]

Cc'd msanz because this is L12Y issue.

Comment 9

[bobj]

Really cc'd msanz this time.

Comment 10

[msanz]

adding dependency for 12394

Comment 11

[(not reading, please use [e-mail] instead)]

adding tobias to the cc list.  he's going to look into fixing this.

Comment 12

[(not reading, please use [e-mail] instead)]

yes, this will require a new string bundle, as "Local Folders" (for the UI, see 
nsMessengerMigrator.cpp) under mozilla/mailnews/base

there will probably be other hard coded ui string that need to be moved into 
that string bundle.

Comment 13

[selmer (gone)]

Mass moving M16 to M17 - look for nsbeta2 before anything else.

Comment 14

[Alec Flett]

the string bundle service caches string bundles for us now, so we shouldn't have
to.

Comment 15

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 16

[(not reading, please use [e-mail] instead)]

giving my i18n bugs to alecf.

thanks alec.

Comment 17

[Alec Flett]

fix in hand, waiting for tree to open

Comment 18

[Alec Flett]

fix is in

Comment 19

[lchiang]

kat - can you verify?

Comment 20

[Katsuhiko Momoi]

OK. I'll ad this to my list.

Comment 21

[Katsuhiko Momoi]

** Checked with 8/2/2000 Win32 M17 build **

So basically this is the backend which enabled Bug 33852
to be fixed. A definition string is now available for "Local
Folders" and when it is translated, we can see the translation
rather than the original.
In thi sense, it is fixed. 
But what about Inbox, Sent, Draft, etc. defalt folders?
I still see them in English even when they are translated.

Marking the fix verified for "Local Folders" but still
puzzled about default folder names.