1836438 - Should not store normalized name while capturing address

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P2)

Description

[Dimi Lee [:dimi]]

We call _normalizeRecord before comparing address, however, we save the normalized address instead of users input. We need to make sure we capture users input so users don't lose their data.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1836438 - Add "full-name" field to address autofill storage r=#credential-management-reviewers

Autofill Storage consists of two parts: Valid Fields and Computed Fields.
Valid Fields should store values provided by users, while Computed Fields are
values we derive from the user-provided data. For example, when a user
enters a "tel" number, we compute "tel-country-code", "tel-national", and
"tel-area-code" based on the "tel" number provided.

However, in the current format, the "name" field is stored as a computed field,
while "given/additional/family" names are stored as valid fields. This approach
can lead to the loss of user input. For instance, if a user enters "Mr. John Doe"
as the name, the current approach strips the "Mr." part and stores"John" as the
given name and "Doe" as the family name. When the next time we autofill
a "name" field, we will then only fill in "John Doe"

This patch introduces a "full-name" field to ensure the user's input is always
stored. When retrieving data from the storage, we will compute the "name"
field based on this "full-name".

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1836438 - P1. Add "full-name" field to address autofill storage r=#credential-management-reviewers

Autofill Storage consists of two parts: Valid Fields and Computed Fields.
Valid Fields should store values provided by users, while Computed Fields are
values we derive from the user-provided data. For example, when a user
enters a "tel" number, we compute "tel-country-code", "tel-national", and
"tel-area-code" based on the "tel" number provided.

However, in the current format, the "name" field is stored as a computed field,
while "given/additional/family" names are stored as valid fields. This approach
can lead to the loss of user input. For instance, if a user enters "Mr. John Doe"
as the name, the current approach strips the "Mr." part and stores"John" as the
given name and "Doe" as the family name. When the next time we autofill
a "name" field, we will then only fill in "John Doe"

This patch introduces a "full-name" field to ensure the user's input is always
stored. When retrieving data from the storage, we will compute the "name"
field based on this "full-name".

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1836438 - P2. Use a single name field for edit address dialog r=#credential-management-reviewers

Merge the First Name, Middle Name, and Last Name fields in the address management
dialog into a single Name field, similar to what we currently have in the edit
address doorhanger.

The reason for this change is not just to synchronize the design.
The main motivation is that a single name field allows users to enter names with
more information, for example, Mr. John Doe. Since first name + middle name + last name
is a subset of name ,we should not limit what users can enter from the outset.

Depends on D196065

Comment 4

[Dimi Lee [:dimi]]

Attachment: Bug 1836438 - P1. Move "name" to VALID_FIELDS and move "*-name" to COMPUTED_FIELDS r=#credential-management-reviewers

Autofill Storage consists of two parts: Valid Fields and Computed Fields.
Valid Fields should store values provided by users, while Computed Fields are
values we derive from the user-provided data. For example, when a user
enters a "tel" number, we compute "tel-country-code", "tel-national", and
"tel-area-code" based on the "tel" number provided.

However, in the current format, the "name" field is stored as a computed field,
while "given/additional/family" names are stored as valid fields. This approach
can lead to the loss of user input. For instance, if a user enters "Mr. John Doe"
as the name, the current approach strips the "Mr." part and stores"John" as the
given name and "Doe" as the family name. When the next time we autofill
a "name" field, we will then only fill in "John Doe"

This patch moves the "name" field to valid fields to ensure the user's input is always
stored.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22a1f02ccf92
P1. Move "name" to VALID_FIELDS and move "*-name" to COMPUTED_FIELDS r=credential-management-reviewers,markh,sgalich
https://hg.mozilla.org/integration/autoland/rev/8f688ebed34e
P2. Use a single name field for edit address dialog r=credential-management-reviewers,issammani

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1836438) for causing xpc failures in test_autofillFormFields.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8f688ebed34e24b876330dc1811d16f542552354&searchStr=os%2Cx%2C11%2Cwebrender%2Cshippable%2Copt%2Cxpcshell%2Ctests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-macosx1100-64-shippable-qr%2Fopt-xpcshell-spi-nw%2Cx1

Log: https://treeherder.mozilla.org/logviewer?job_id=443782015&repo=autoland&lineNumber=5452

Backout: https://hg.mozilla.org/integration/autoland/rev/a47eb4a27793a377fd230a4982365969bbb32d5f

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/22a1f02ccf92
https://hg.mozilla.org/mozilla-central/rev/8f688ebed34e

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73a1728e9257
P1. Move "name" to VALID_FIELDS and move "*-name" to COMPUTED_FIELDS r=credential-management-reviewers,markh,sgalich
https://hg.mozilla.org/integration/autoland/rev/e2f90fb83fb8
P2. Use a single name field for edit address dialog r=credential-management-reviewers,issammani

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/73a1728e9257
https://hg.mozilla.org/mozilla-central/rev/e2f90fb83fb8