Tab history from one SERP to another can be recorded as a non-ad click
Categories
(Firefox :: Search, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox-esr115 | --- | fixed |
firefox114 | --- | unaffected |
firefox115 | --- | fixed |
firefox116 | --- | fixed |
People
(Reporter: jteow, Assigned: jteow)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [snt-scrubbed])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-release+
dmeehan
:
approval-mozilla-esr115+
|
Details | Review |
As mentioned in Bug 1835267, the tab history can trigger a "click" event due to the fact that the URL matches a SERP, as we've made the allowable non ad links more permissive.
Could be the same with bookmarks or manually entering a URL that's a SERP? It might a timing issue.
Assignee | ||
Comment 1•2 years ago
|
||
Digging deeper into this, the reason why we don't hit this issue with launching requests of SERP urls from the Urlbar or loading bookmarks of SERPs is because the originURL will be null, thus we won't find an item and we'll early return.
Using Back/Forward is slightly different. Because we're now subscribing to cache events (so that we record clicks on non ad links that could be cached), SERPs can be accessed via a cached event.
Assignee | ||
Comment 2•1 years ago
|
||
Assignee | ||
Updated•1 years ago
|
Updated•1 years ago
|
Updated•1 years ago
|
Updated•1 years ago
|
Comment 4•1 years ago
|
||
bugherder |
Updated•1 years ago
|
Comment 5•1 years ago
|
||
The patch landed in nightly and beta is affected.
:jteow, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox115
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Updated•1 years ago
|
Assignee | ||
Comment 7•1 years ago
|
||
Opting for wontfix
in 115 because we haven't validated the data for current users in Nightly yet, so there's a strong chance the full experiment won't be run on release till post-115.
Comment 8•1 year ago
|
||
(In reply to James Teow [:jteow] from comment #7)
Opting for
wontfix
in 115 because we haven't validated the data for current users in Nightly yet, so there's a strong chance the full experiment won't be run on release till post-115.
We have decided to uplift the fix to 115 dot release to run the experiment earlier.
Comment 9•1 year ago
|
||
Comment on attachment 9337479 [details]
Bug 1836507 - Prevent tab-history events from triggering a click event - r?standard8,scunnane
Beta/Release Uplift Approval Request
- User impact if declined: Improvement to new Search SERP Ad telemetry that we would like to turn on a bit earlier. Improves handling of reporting when using tab history.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small change to telemetry-only analysis code in a well-tested area.
- String changes made/needed: None
- Is Android affected?: No
Comment 10•1 year ago
|
||
Comment on attachment 9337479 [details]
Bug 1836507 - Prevent tab-history events from triggering a click event - r?standard8,scunnane
Approved for 115.0.2
Approved for 115.0.2esr
Updated•1 year ago
|
Comment 11•1 year ago
|
||
uplift |
Updated•1 year ago
|
Comment 12•1 year ago
|
||
uplift |
Updated•1 year ago
|
Comment 13•1 year ago
|
||
uplift |
Comment 14•1 year ago
|
||
Tagging as a qe- for this issue. We have tcs coverage and verification has been done for bug 1835267 which is a particular case while this is the general one.
Description
•