1836741 - Add initial trustwerty/fakespot client to fetch product information

Status: RESOLVED FIXED

(Firefox :: Shopping, task, P2)

Description

[:Gijs (out for now; he/him)]

We should start building an API client in-tree. This should live in browser/components/shopping/, and it should not return anything unless the nimbus feature (bug 1836265) is enabled, and the user has opted in (bug 1836740).

The API notes doc should help with doing this.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Correction to comment 0 - we want the API client code to live in toolkit, not in browser, so the android front-end can also use it.

Comment 2

[Fred Chasen [:fchasen]]

Attachment: Bug 1836741 - Shopping product client r=#shopping-reviewers

• Adds a shopping component in toolkit.
• Creates a Product client to handle fetching and validating from the Shopping APIs.
• Product config allows updating the shopping sites list and product id regex for each site.
• Creates JSON schemas for validating the API responses.

Comment 3

[Fred Chasen [:fchasen]]

Attachment: WIP: Bug 1836741 - Export getProductInfoFromURL and isProductURL functions from ShoppingProduct

Comment 4

[Fred Chasen [:fchasen]]

Attachment: Bug 1836741 - Add isProductURL check in ShoppingProduct r=jhirsch

Adds an exported isProductURL(url) function that can accept a url string, nsIURI or URL and return if that url contains product information.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed1685687f2a
Shopping product client r=jhirsch

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures due to ProductConfig.mjs

• backout: https://hg.mozilla.org/integration/autoland/rev/03719540828f415eaf6538ceb73d69e9b7260747
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=ed1685687f2a3bce096f8b9f8fb3264ee400628b&selectedTaskRun=Vn_K9kbXR5K6cQHFOMTUFg.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=420858708&repo=autoland&lineNumber=3525

[task 2023-06-27T23:53:31.249Z] 23:53:31     INFO - Buffered messages finished
[task 2023-06-27T23:53:31.251Z] 23:53:31     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 5, expected +0
[task 2023-06-27T23:53:31.251Z] 23:53:31     INFO - Stack trace:
[task 2023-06-27T23:53:31.251Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:test_is:1608
[task 2023-06-27T23:53:31.251Z] 23:53:31     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1026
[task 2023-06-27T23:53:31.252Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:handleTask:1131
[task 2023-06-27T23:53:31.252Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1203
[task 2023-06-27T23:53:31.252Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1345
[task 2023-06-27T23:53:31.253Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1120
[task 2023-06-27T23:53:31.253Z] 23:53:31     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1056
[task 2023-06-27T23:53:31.254Z] 23:53:31     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-06-27T23:53:31.255Z] 23:53:31     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | file only referenced from unreferenced files: chrome://global/content/shopping/ProductConfig.mjs referenced from chrome://global/content/shopping/ShoppingProduct.mjs - 
[task 2023-06-27T23:53:31.255Z] 23:53:31     INFO - Stack trace:
[task 2023-06-27T23:53:31.256Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2023-06-27T23:53:31.256Z] 23:53:31     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1037
[task 2023-06-27T23:53:31.256Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:handleTask:1131
[task 2023-06-27T23:53:31.257Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1203
[task 2023-06-27T23:53:31.257Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1345
[task 2023-06-27T23:53:31.258Z] 23:53:31     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1120
[task 2023-06-27T23:53:31.258Z] 23:53:31     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1056
[task 2023-06-27T23:53:31.259Z] 23:53:31     INFO - Not taking screenshot here: see the one that was previously logged

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/675fc641f30a
Shopping product client r=jhirsch

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/675fc641f30a

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a60baa68669b
Add isProductURL check in ShoppingProduct r=jhirsch

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0873af398c2c
Backed out changeset a60baa68669b for causing xpcshell failures on test_product.js.

Comment 11

[Cosmin Sabou [:CosminS]]

Backed out for causing xpcshell failures on test_product.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=a60baa68669b1d5df71edae212b893831d2aa02c&searchStr=xpc&selectedTaskRun=J3n1Ryl2Q_mcVCYYoo8zNA.0

Failure logs:

• xpcshell https://treeherder.mozilla.org/logviewer?job_id=421628106&repo=autoland
• browser chrome - https://treeherder.mozilla.org/logviewer?job_id=421626921&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/0873af398c2c088cb8120b4d1886920dc617f8cb

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f69c86c9261
Add isProductURL check in ShoppingProduct r=jhirsch

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7f69c86c9261