1836886 - [wl_pointer.axis_value120] Firefox does not support high resolution scrollwheels in Wayland mode

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[kode54]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

1. Install Firefox Nightly.
2. Run it with MOZ_USE_XINPUT2=1 set and GDK_CORE_DEVICE_EVENTS unset.
3. Browser runs in Wayland mode.

Actual results:

My MX Master 3 is locked to large wheel steps, under GNOME, Plasma, and wlroots compositors.

Expected results:

My mouse's reported high precision scrolling events should trigger fine scrolling in the browser.

Comment 1

[kode54]

This problem does not occur if I force it to run under Xwayland and enable the xinput2 mode.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Does this happen with other GTK applications?

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Seems to be implemented in wayland 1.21 by wl_pointer.axis_value120 interface (https://lists.freedesktop.org/archives/wayland-devel/2022-May/042194.html). It should be implemented by somehow who owns such hardware.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Does this happen with other GTK applications?

I guess it's Gtk4 only.

Comment 6

[Aleksandar]

+1 for this bug. Running Fedora 39 using the Wayland session. On x11, firefox notices the high resolution scroll events and behaves as expected. Using Wayland, firefox only scrolls on the low resolution event. Trackpad scrolling is smooth as expected on both. Aside from firefox, only gtk3 apps do not use the high resolution scroll, everything works on gtk4, chrome (wayland and x11), electron...

To reproduce this bug without the required hardware, you could possibly use libinput-config (https://gitlab.com/warningnonpotablewater/libinput-config) and set discrete-scroll-factor-y=0.125

Comment 7

[Ivan Shapovalov]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #4)

Seems to be implemented in wayland 1.21 by wl_pointer.axis_value120 interface (https://lists.freedesktop.org/archives/wayland-devel/2022-May/042194.html). It should be implemented by somehow who owns such hardware.

I own relevant hardware and am in need of this feature; do you have any pointers (for someone familiar with the concepts, but unfamiliar with the codebase) where to start implementing?

Comment 8

[Martin Stránský [:stransky] (ni? me)]

This may be related:
https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/652

I'm not sure how it's integrated with Gtk3 (Firefox uses Gtk3 toolkit to get mouse events).

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Looks like it was merged to Gtk4 only. We'd need Gtk3 packport for it.
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3839

Comment 11

[xorly]

I want to correct one observation. As I observed in bug 1902839:

Page scrolls once per 7~8 EV_REL / REL_WHEEL_HI_RES events by same amount as with mouse with normal wheel. When scrolling slowly, one hires event is 16° in my case. FF scrolling is not synchronous to EV_REL / REL_WHEEL (non high resolution) events, so it looks like input stack is processing hires events, but it somehow pre-scales them and then scrolls in coarser steps.

Impact of this fact is quite annoying. When I focus FF and scroll wheel is not aligned, then enable ratcheting on the mouse, not every "click" of the wheel produces 1 step of page scroll. Some wheel "clicks" result in none and other in 2 scroll steps in FF.

I will attach libinput recording file, yo you can replay it on your systems.

Comment 12

[xorly]

Attachment: libinput record output for Logitech master 3S scroling

libinput record output for Logitech master 3S scrolling:

• scroll down
• scroll up
• scroll down,
• repeated very short scrolls up/down

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1836886 [Wayland] Implement smooth scrolling r?emilio,botond

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Botond, for the smooth/hi-res scroll we use right now:

  WidgetWheelEvent wheelEvent(true, eWheel, this);
  wheelEvent.mDeltaMode = dom::WheelEvent_Binding::DOM_DELTA_LINE;
  wheelEvent.mDeltaX = aDeltaX * 3;
  wheelEvent.mDeltaY = aDeltaY * 3;
  wheelEvent.mWheelTicksX = aDeltaX;
  wheelEvent.mWheelTicksY = aDeltaY;
  wheelEvent.mIsNoLineOrPageDelta = true;

I wonder if there's any other settings we may use, close to touch scroll perhaps?
Thanks.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dfed78115dc
[Wayland] Implement smooth scrolling r=emilio

Comment 17

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_disableSwipeGestures.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a762b5fe92d9c9097ad08857c5b5c7457f2e8e56

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_disableSwipeGestures.js | Test timed out

Failure log -> TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/browser_test_background_tab_scroll.js | Test timed out

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae042b115f6f
[Wayland] Implement smooth scrolling r=emilio

Comment 20

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ae042b115f6f

Comment 21

[Botond Ballo [:botond]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #15)

Botond, for the smooth/hi-res scroll we use right now:

  WidgetWheelEvent wheelEvent(true, eWheel, this);
  wheelEvent.mDeltaMode = dom::WheelEvent_Binding::DOM_DELTA_LINE;
  wheelEvent.mDeltaX = aDeltaX * 3;
  wheelEvent.mDeltaY = aDeltaY * 3;
  wheelEvent.mWheelTicksX = aDeltaX;
  wheelEvent.mWheelTicksY = aDeltaY;
  wheelEvent.mIsNoLineOrPageDelta = true;

I wonder if there's any other settings we may use, close to touch scroll perhaps?

Apologies for the delay.

I assume you mean touchpad rather than touchscreen, since touchpad seems like the closer analogue to hi-res mousewheel (for touchscreen, the logic is a more simple "the page moves as much as your finger did").

The only thing that comes to mind is perhaps using the method of computing deltas for a touchpad here (with the delta type being set to DOM_DELTA_PIXEL or DOM_DELTA_PAGE depending on isPageMode).

I don't have a good sense of how much of an improvement that would be in practice.