1836999 - Clean up allowed-dups.mn & stop including the browser allowed-dups.mn

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

As pointed out in bug 1836899, Thunderbird's allowed-dups check includes the browser version of the file as well as the one from comm/mail.

bug 1313670 comment 45 suggests that this was originally done to avoid duplicating a whole mess of duplicates from devtools.

Those devtools duplicates are no longer a thing, so no reason to include the browser allowed-dups file!

allowed-dups.mn in general needs cleanup anyway.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1836999 - Stop reading browser's allowed-dups.mn & clean up stale entries in mail's. r=#thunderbird-build-system-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/368b9ea07b82
Stop reading browser's allowed-dups.mn & clean up stale entries in mail's. r=dandarnell

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9337698 [details]
Bug 1836999 - Stop reading browser's allowed-dups.mn & clean up stale entries in mail's. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: minimal to zero
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low risk - this is packaging cleanup. To remove allowed "duplicate" files in omni.ja. In the end, the result is the same omni.ja file.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9337698 [details]
Bug 1836999 - Stop reading browser's allowed-dups.mn & clean up stale entries in mail's. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/876425f0dc93

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 115.0b2 - backout:
https://hg.mozilla.org/releases/comm-beta/rev/289561a0a2d4

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/23d3e51e8422