1837008 - Open file dialogs prevent shutdown until closed

Status: ASSIGNED

(Core :: Widget: Win32, defect, P5)

Description

[Ray Kraesig [:rkraesig]]

Steps to reproduce:

1. Open two browser windows.
2. In the first window, go to data:text/html,<input type=file>. Click the button, but do not select a file.
3. In the second window, press Ctrl+Shift+Q to shut down Firefox.

Actual behavior:

Firefox closes all windows except for the file dialog, which must be manually dismissed.

Expected behavior:

Firefox closes all windows, including any open file dialogs (possibly warning the user and requesting confirmation first).

Comment 1

[Ray Kraesig [:rkraesig]]

This bug is not, strictly speaking, dependent on bug 1677170; but it may be easier to implement after or as part of that bug.

Comment 3

[Ray Kraesig [:rkraesig]]

This doesn't necessarily depend on bug 1870660: once file-pickers are consistently opened out-of-process, we can just kill their host process. That much is done automatically in release builds, but may need some extra work otherwise — and we also have to take care to disable the fallback to in-process pickers at that point, if they're still active.

(At present all our open file-dialogs are opened by the same host-process, so we can't use that mechanism to implement an individualized Close() function. For shutdown, though, that should be fine.)

Comment 5

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1837008 - [1/2] Fix crash when logging to `FileDialog` r?#win-reviewers!

If a path was not provided to SendFailureNotification while
file-dialog logging was active, a crash would occur. Check for and
handle this case.

Comment 6

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1837008 - [2/2] Terminate file-dialog process early if needed r?#ipc-reviewers!

File dialogs are opened on a separate thread, but these threads can't be
convinced to wind down normally. If they're still around at process
shutdown time (as may be the case at session-end), skip any remaining
cleanup and just kill the process.