1837061 - [wmfme] support HWDRM query for WMFCDM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

This bug will set the robustness on the capabilities properly which is returned from the MFCDM process, so that we would be able to play DRM video when capabilities from a query contain robustness.

This test page and this one can be used to test different robustness.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part1 : support HWDRM query in MFCDM.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part2 : print debug information for the key system config.

Depends on D180160

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part3 : remove unused member variable.

Depends on D180161

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part4 : allow to generate multiple key system configs for one system.

Eg. Hardware secure and software secure can have a completely different
supported configs.

Depends on D180162

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part5 : compare candidate config from multiple configs to know if it's supported.

Depends on D180163

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part6 : query HWDRM for WMFCDM.

Depends on D180272

Comment 7

[Alastor Wu [:alwu]]

Attachment: WIP: Bug 1837061 - part7 : do a real CDM creation check to know whether HWDRM is available.

Unfortunately IMFContentDecryptionModuleFactory::IsTypeSupported can't
get the correct result when the query is about HWDRM. It would always
return true, and it seems not checking any of features we set.

Therefore, we need to create a dummy CDM to see whether a CDM can be
created or not.

Depends on D180273

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part7 : always set persistentState and distinctiveID on MFCDMCapabilitiesIPDL to avoid assertion caused by unintialized value during serialization.

If we don't do that, returning an empty capabilities would hit the
assertion when serializing MFCDMCapabilitiesIPDL, which might be caused
by uninitialized random value.

[1]
https://searchfox.org/mozi887d4b5da89a1192lla-central/rev/0ed0fd96b7b7f066927a67db/ipc/glue/EnumSerializer.h#60-61

Depends on D180274

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part8 : cached capabilities for key systems in order to reduce unnecessary IPC calls.

Depends on D180275

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part9 : disconnect requests on the manager thread because disconnect is not threadsafe.

Depends on D180371

Comment 12

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part10 : make MFCDMProxy refcount thread-safe.

Depends on D180399

Comment 13

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part11 : set robustness for audio as well.

Depends on D180497

Comment 14

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part12 : set IsHWSecure correctly when initialzing CDM.

Comment 15

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part12 : set the real audio and video capabilities when creating a CDM.

Depends on D180507

Comment 16

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part13 : do a real CDM creation check to know whether HWDRM is available.

Depends on D180898

Comment 17

[Alastor Wu [:alwu]]

Attachment: Bug 1837061 - part14 : remove hw secure from MFCDMInitParamsIPDL.

Depends on D180899

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b166e029e637
part1 : support HWDRM query in MFCDM. r=jolin
https://hg.mozilla.org/integration/autoland/rev/2bc87fa183d2
part2 : print debug information for the key system config. r=jolin
https://hg.mozilla.org/integration/autoland/rev/f33eae9dd3c6
part3 : remove unused member variable. r=jolin
https://hg.mozilla.org/integration/autoland/rev/ab4dbaa9c4f0
part4 : allow to generate multiple key system configs for one system. r=jolin
https://hg.mozilla.org/integration/autoland/rev/9d3bedaac661
part5 : compare candidate config from multiple configs to know if it's supported. r=jolin
https://hg.mozilla.org/integration/autoland/rev/31fa48139408
part6 : query HWDRM for WMFCDM. r=jolin
https://hg.mozilla.org/integration/autoland/rev/b4ecd3852aa0
part7 : always set persistentState and distinctiveID on MFCDMCapabilitiesIPDL to avoid assertion caused by unintialized value during serialization. r=jolin
https://hg.mozilla.org/integration/autoland/rev/4c8e63e3135b
part8 : cached capabilities for key systems in order to reduce unnecessary IPC calls. r=jolin
https://hg.mozilla.org/integration/autoland/rev/ad92333be810
part9 : disconnect requests on the manager thread because disconnect is not threadsafe. r=jolin
https://hg.mozilla.org/integration/autoland/rev/bda83c36ca2d
part10 : make MFCDMProxy refcount thread-safe. r=jolin
https://hg.mozilla.org/integration/autoland/rev/f8540a22a2cc
part11 : set robustness for audio as well. r=jolin
https://hg.mozilla.org/integration/autoland/rev/9529a2650676
part12 : set the real audio and video capabilities when creating a CDM. r=jolin
https://hg.mozilla.org/integration/autoland/rev/f770fd07a8e8
part13 : do a real CDM creation check to know whether HWDRM is available. r=jolin
https://hg.mozilla.org/integration/autoland/rev/9d6b12a756cb
part14 : remove hw secure from MFCDMInitParamsIPDL. r=jolin

Comment 19

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b166e029e637
https://hg.mozilla.org/mozilla-central/rev/2bc87fa183d2
https://hg.mozilla.org/mozilla-central/rev/f33eae9dd3c6
https://hg.mozilla.org/mozilla-central/rev/ab4dbaa9c4f0
https://hg.mozilla.org/mozilla-central/rev/9d3bedaac661
https://hg.mozilla.org/mozilla-central/rev/31fa48139408
https://hg.mozilla.org/mozilla-central/rev/b4ecd3852aa0
https://hg.mozilla.org/mozilla-central/rev/4c8e63e3135b
https://hg.mozilla.org/mozilla-central/rev/ad92333be810
https://hg.mozilla.org/mozilla-central/rev/bda83c36ca2d
https://hg.mozilla.org/mozilla-central/rev/f8540a22a2cc
https://hg.mozilla.org/mozilla-central/rev/9529a2650676
https://hg.mozilla.org/mozilla-central/rev/f770fd07a8e8
https://hg.mozilla.org/mozilla-central/rev/9d6b12a756cb