1837168 - Rework user activation checks for requestStorageAccess

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P2)

Description

[Benjamin VanderSloot [:bvandersloot]]

We need to match the current status of the spec algorithm. This means probably removing Step 0 from Document::RequestStorageAccess and moving this check later in the logic of requesting storage access.

Comment 1

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1837168 - Moved transient activation check to match the spec for storage access api. r?bvandersloot

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1837168 - Update user activation check to be after the permission check - r=timhuang!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d21bdbf5baf1
Update user activation check to be after the permission check - r=timhuang,anti-tracking-reviewers

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for assertion failure on PermissionManager.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/072cb0ddcc54c39e69e7ba612f2319f78ef6f8c1
Log link: https://treeherder.mozilla.org/logviewer?job_id=429664159&repo=autoland&lineNumber=10097

There were also perma dt failures on browser_webconsole_requestStorageAccess_errors.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15a005bef445
Update user activation check to be after the permission check - r=timhuang,anti-tracking-reviewers

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing storage-access-api wpt failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=71a9b5a8ec8503f993e8d7e8f1b2b98ff57ed283&selectedTaskRun=DFEszt37T2eJNJjVlvHUHA.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=429754383&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=429754821&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=429754854&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e92c707a3c07751b6cb435402ee8969f02b6b82

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ff5b92032cb
Update user activation check to be after the permission check - r=timhuang,anti-tracking-reviewers

Comment 8

[Iulian Moraru]

Backed out 9 changesets (bug 1848783, bug 1837168, bug 1835920) for causing multiple failures.

• Push with failures

• Failure log for mochitest-plain failures

• Failure log for wpt failures

• Backout link

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd3e3766443a
Update user activation check to be after the permission check - r=timhuang,anti-tracking-reviewers

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fd3e3766443a