Closed Bug 1848783 Opened 3 years ago Closed 2 years ago

Fix WPT failures left after set_permission is enabled for storage-access

Categories

(Core :: Privacy: Anti-Tracking, enhancement)

Product:
Core
Component:
Privacy: Anti-Tracking
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: bvandersloot, Assigned: bvandersloot)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

Bug 1848783, part 1 - Add active document check - r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1848783, part 2 - Reorder checks in CheckCallingContextDecidesStorageAccessAPI - r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1848783, part 3 - Add the site (sans port) to the permission keys of a content process - r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1848783, part 4 - Don't send storage-access status update to same-origin frames in frame-only mode - r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1848783, part 5 - Move UsingStorageAccess onto the WindowContext to fix the storage access check for resource reuqests within subdocuments without active storage access but with permission r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1848783, part 6 - Revoke has storage access when the permission is revoked - r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1848783, part 7 - Update WPT ini files - r=#anti-tracking!
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → bvandersloot
Status: NEW → ASSIGNED

Also, remove a too-early check for third-partyness from StorageAccessAPIHelper::CheckBrowserSettingsDecidesStorageAccessAPI- that gets checked later anyway and should not override an inactive document

Depends on D186982

without this, permissions set in the main process that are site-scoped on origins with non-null ports are not pushed out to the content process.

Depends on D186983

We already had cross-origin-but-same-site covered. But the WPT exposed same-origin as a bug.

Depends on D186984

Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f17d58a27f3c part 1 - Add active document check - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/e1b829bfb8d1 part 2 - Reorder checks in CheckCallingContextDecidesStorageAccessAPI - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/01f053bbdb97 part 3 - Add the site (sans port) to the permission keys of a content process - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/bfd4df9014d7 part 4 - Don't send storage-access status update to same-origin frames in frame-only mode - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/1b5a505a9bc6 part 5 - Move UsingStorageAccess onto the WindowContext to fix the storage access check for resource reuqests within subdocuments without active storage access but with permission r=timhuang,nika https://hg.mozilla.org/integration/autoland/rev/7446d643420d part 6 - Revoke has storage access when the permission is revoked - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/589241e4e1f6 part 7 - Update WPT ini files - r=anti-tracking-reviewers,timhuang

Backed out for assertion failure on PermissionManager.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/072cb0ddcc54c39e69e7ba612f2319f78ef6f8c1
Log link: https://treeherder.mozilla.org/logviewer?job_id=429664159&repo=autoland&lineNumber=10097

There were also perma dt failures on browser_webconsole_requestStorageAccess_errors.js

Flags: needinfo?(bvandersloot)

I didn't test against reftests or devtools because I thought the changes here would be covered well enough by bc, chrome, and mochitests. fixes incoming, after looking through the full set of failures on the provided job.

Flags: needinfo?(bvandersloot)
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8bb89cf9587e part 1 - Add active document check - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/84ca25a557a6 part 2 - Reorder checks in CheckCallingContextDecidesStorageAccessAPI - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/7dc5f794364d part 3 - Add the site (sans port) to the permission keys of a content process - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/3a14281b7d72 part 4 - Don't send storage-access status update to same-origin frames in frame-only mode - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/117132b000ac part 5 - Move UsingStorageAccess onto the WindowContext to fix the storage access check for resource reuqests within subdocuments without active storage access but with permission r=timhuang,nika https://hg.mozilla.org/integration/autoland/rev/a96afb6d05d6 part 6 - Revoke has storage access when the permission is revoked - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/3fd66f8f5d65 part 7 - Update WPT ini files - r=anti-tracking-reviewers,timhuang

I missed that Android behaves differently due to config differences, so I didn't run wpt there. taking the wptreport.json from this run as an update.

Also, there was another minor wpt failure in a new tentative test in html/anonymous-iframe. I've added expected: FAIL for those too.

Flags: needinfo?(bvandersloot)
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d1468ac6e84 part 1 - Add active document check - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/735161c251e4 part 2 - Reorder checks in CheckCallingContextDecidesStorageAccessAPI - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/cb56c5d713bf part 3 - Add the site (sans port) to the permission keys of a content process - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/e082ba20bbb2 part 4 - Don't send storage-access status update to same-origin frames in frame-only mode - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/1f64106e6667 part 5 - Move UsingStorageAccess onto the WindowContext to fix the storage access check for resource reuqests within subdocuments without active storage access but with permission r=timhuang,nika https://hg.mozilla.org/integration/autoland/rev/de5e1715c877 part 6 - Revoke has storage access when the permission is revoked - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/ab1717421318 part 7 - Update WPT ini files - r=anti-tracking-reviewers,timhuang

Backed out 9 changesets (bug 1848783, bug 1837168, bug 1835920) for causing multiple failures.

Flags: needinfo?(bvandersloot)

I think the mochitest-plain failure is an unrelated intermittent. I can't get it to reproduce locally, even with xorigin tests enabled.

The wpt failure is a correctly attributed intermittent wherein all subtests pass, but the test runner times out. I'm adding [OK, TIMEOUT] expectations to those tests and a few other tests that use the same helpers that might suffer from the same intermittent failure.

All other failures in that push look unrelated. Hearing no complaints, I'm going to re-push with the wpt ini files updated to be permissive of intermittent timeouts.

Flags: needinfo?(bvandersloot)

The mochitest was permafailing and the backfills point to the push that I've backed out.
You can check the backfills in this backfill range.
Maybe it is not this specific revision for wpt, maybe it's something else from that push?

Flags: needinfo?(bvandersloot)
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f6a610946bd1 part 1 - Add active document check - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/c2491de30c72 part 2 - Reorder checks in CheckCallingContextDecidesStorageAccessAPI - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/b58e27b64cb0 part 3 - Add the site (sans port) to the permission keys of a content process - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/b7b2e5374b5d part 4 - Don't send storage-access status update to same-origin frames in frame-only mode - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/fbffb07bb176 part 5 - Move UsingStorageAccess onto the WindowContext to fix the storage access check for resource reuqests within subdocuments without active storage access but with permission r=timhuang,nika https://hg.mozilla.org/integration/autoland/rev/7466cc9b1831 part 6 - Revoke has storage access when the permission is revoked - r=anti-tracking-reviewers,timhuang https://hg.mozilla.org/integration/autoland/rev/19eb3d212504 part 7 - Update WPT ini files - r=anti-tracking-reviewers,timhuang
Flags: needinfo?(bvandersloot)
Regressions: 1854367
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: