1837349 - The new migration window accepts importing any type of file when using the Import Bookmarks from HTML option

Status: RESOLVED DUPLICATE of bug 1837367

(Firefox :: Migration, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: bookmarks_html.gif

Found in

• 115.0b2

Affected versions

• 116.0a1 (2023-06-07)
• 115.0b2

Tested platforms

• Affected platforms: Windows10 x64, Ubuntu 20.04, macOS 12
• Unaffected platforms: none

Preconditions

• browser.migrate.content-modal.enabled: true

Steps to reproduce

1. Open the new migration window and select Bookmarks from HTML file.
2. On the Import Bookmarks File window choose All files.
3. Import a random file.

Expected result

• Only HTML files are available.

Actual result

• Importing a random file that is not a .html file will display a Bookmarks Imported Successfully window that contains the imported entries variable displayed.

Regression range

• Not a regression, it started happening with the implementation of Bookmark importing from HTML files (bug 1833427).

Additional notes

• Attached a screen recording.
• The issue cannot be reproduced with the legacy migration window.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:atrif, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[:Gijs (out for now; he/him)]

I think having "all files" be present here is somewhat expected (thinking particularly of backup .bak files and whatnot), but we shouldn't provide bogus feedback when a file is selected that has no meaningful bookmarks. Mike, is that right?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Yes, that's correct! This should be fixed by bug 1837367, fwiw.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

This should be fixed by bug 1837367 now. atrif, can you confirm?

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #4)

This should be fixed by bug 1837367 now. atrif, can you confirm?

Sure. Confirming that after following the steps from comment 0 with Firefox 116.0a1 (2023-06-19) on Windows 10x64, macOS 12 and Ubuntu 20.05 a The file doesn't include any bookmark data. Pick another file. error is displayed giving the user an option to click on the Select File button to choose another file or to Cancel the file import. The $newEntries string is no longer displayed.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Great, thanks!