1837367 - No error is displayed when importing an empty HTML file

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: bookmarks_html_empty.gif

Found in

• 115.0b2

Affected versions

• 116.0a1 (2023-06-07)
• 115.0b2

Tested platforms

• Affected platforms: Windows10 x64, Ubuntu 20.04, macOS 12
• Unaffected platforms: none

Preconditions

• browser.migrate.content-modal.enabled: true
• empty .html file

Steps to reproduce

1. Open the new migration window and select Bookmarks from HTML file.
2. Import an emty .html file.

Expected result

• An error is displayed giving the user option to select another file per spec doc & Figma

Actual result

• Bookmarks imported Successfully message is displayed.

Regression range

• Not a regression, it started happening with the implementation of Bookmark importing from HTML files (bug 1833427).

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:atrif, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1837367 - Allow file migrators to show an error message if migration failed for some reason. r?kpatenio!

The spec calls for a special-case in the event that file migration
ever fails - the wizard should be sent back to the selection page,
have the associated file migrator still set in the dropdown, and
show an error message.

A later patch in this series will add such an error message for
the bookmarks file migrator.

Depends on D180458

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1837367 - Throw an error if the bookmarks file migrator doesn't import anything. r?tgiles!

An earlier patch in the series makes the error message appear in the
migration wizard on the selection page.

Depends on D180490

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/495fb1f0b390
Allow file migrators to show an error message if migration failed for some reason. r=kpatenio,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/7c7141d4f489
Throw an error if the bookmarks file migrator doesn't import anything. r=tgiles,fluent-reviewers,flod

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/495fb1f0b390
https://hg.mozilla.org/mozilla-central/rev/7c7141d4f489

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Virgil Sangerean]

Issue is verified-fixed on build provided on treeherder.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

The patch includes a string change, so no, I don't think this should uplift.