Closed Bug 1837392 Opened 1 years ago Closed 1 year ago

Add "Search bookmarks" option in bookmarks menu (in the menu bar)

Categories

(Firefox :: Bookmarks & History, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: jmjjeffery, Assigned: mseibert, Mentored)

References

Details

(Whiteboard: [snt])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1736937 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

  1. Add bookmarks menu button on toolbar
  2. Click to it and it open bookmark menu

Actual results:

Search box in bookmarks menu is not

In example: in Microsoft Edge Chromium search box appear when you click to search icon on bookmarks flyout

Another example: in Firefox on bookmarks sidebar, search box appear

Expected results:

Search box in bookmarks menu should appear

It has been noted that the option to 'Search Bookmarks' is missing when the user Has the Menu Bar enabled and uses the 'Bookmarks'
item in the Menu Bar.
An added feature to 'Search Bookmarks' should appear in this Bookmark list as added in bug 1736937

Whiteboard: [snt]

(note, comment 0 and some of the metadata seems to have been inadvertently cloned from bug 1736937 via the "new bug as clone" flow. I think comment 1 is the real bug report here.)

Just to clarify, I think the STR here are, starting from fresh profile:
(1) Make the menu bar show up, by either (a) pressing "alt" or (b) right clicking a blank space in Firefox toolbar, and check the checkbox for "menu bar"
(2) Click "Bookmarks" in the menu bar.

ACTUAL RESULTS:
Bookmarks menu doesn't have a "Search bookmarks" menu item.

EXPECTED RESULTS:
Bookmarks menu should have a "Search bookmarks" menu item (just like the Bookmarks and Library toolbar-button popup-menus do, added in bug 1736937)

(This menu item would presumably just focus the location bar with [Bookmarks] search; that's what happens for this menu item in the toolbar-button popup menus.)

Summary: Add "Search bookmarks" option in bookmarks menu → Add "Search bookmarks" option in bookmarks menubar menu
Version: Firefox 93 → Trunk
Summary: Add "Search bookmarks" option in bookmarks menubar menu → Add "Search bookmarks" option in bookmarks menu (in the menu bar)

(In reply to Daniel Holbert [:dholbert] from comment #2)

(note, comment 0 and some of the metadata seems to have been inadvertently cloned from bug 1736937 via the "new bug as clone" flow. I think comment 1 is the real bug report here.)

Just to clarify, I think the STR here are, starting from fresh profile:
(1) Make the menu bar show up, by either (a) pressing "alt" or (b) right clicking a blank space in Firefox toolbar, and check the checkbox for "menu bar"
(2) Click "Bookmarks" in the menu bar.

ACTUAL RESULTS:
Bookmarks menu doesn't have a "Search bookmarks" menu item.

EXPECTED RESULTS:
Bookmarks menu should have a "Search bookmarks" menu item (just like the Bookmarks and Library toolbar-button popup-menus do, added in bug 1736937)

(This menu item would presumably just focus the location bar with [Bookmarks] search; that's what happens for this menu item in the toolbar-button popup menus.)

Yes, that is what should be done.

Assignee: nobody → mseibert
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P3
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3404f5e068c6 Add "Search bookmarks" option in bookmarks menu (in the menu bar).r=dao,fluent-reviewers,flod
Regressions: 1840880
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

Verified Fixed with today's Nightly build.

Status: RESOLVED → VERIFIED

Could this maybe be uplifted to Beta, to get it out sooner ?
Sorry, I don't know the exact procedure to request an uplift.

Thanks

Flags: needinfo?(mseibert)

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #8)

Could this maybe be uplifted to Beta, to get it out sooner ?
Sorry, I don't know the exact procedure to request an uplift.

We only uplift important bug fixes to beta, not enhancements. Additionally this includes a string change which must be translated by our localisation teams and they need to be given time to do that.

The planned release day for 116 is 1st August, so you only have to wait about a month.

Flags: needinfo?(mseibert)
Blocks: 713713
Depends on: 1843875
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: