1837498 - Homepage compose views do not resize when orientation changes

Status: ASSIGNED

(Fenix :: Homepage, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Screenshot_20230608-161111.png

The Compose views on the Homepage do not resize to fit the new screen width when we rotate the screen (eg, portrait to landscape).

Steps to reproduce

1. On the Homepage, observe any of the Compose views (eg, Recent Tabs, Collections, etc) and start switching orientations from portrait to landscape. This may require a couple of attempts. Scrolling will recompose the views and display correctly.
2. Observe that the Compose views do not recompose and take up the full max width when the orientation changes.

Expected behavior

The Compose views should resize and take up the max width when the orientation changes.

Actual behavior

The Compose view may stay stuck in its original portrait size until we scroll and the view recomposes.

Comment 1

[eclaudiu64]

Identical to my open ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1827110

Comment 2

[Vlad Dreghici [:vdreghici]]

I have investigated this issue on multiple Android versions, and it seems the issue is reproducible on multiple versions. The issue also seems to be inconsistent, sometimes the recomposition working as intended. I uploaded below three videos from Android versions 9, 10 and 11.

Comment 3

[Vlad Dreghici [:vdreghici]]

Attachment: recomposition_android_9.mp4

In Android 9 the only element that seems to be affected is the header of the "Jump back in" and "Recently visited" sections. As you can see, the issue reproduced only twice, in the first and last rotation of the screen.

Comment 4

[Vlad Dreghici [:vdreghici]]

Attachment: recomposition_android_10.mp4

In this recording, the issue is noticeable bot for landscape and portrait orientations.

Comment 5

[Vlad Dreghici [:vdreghici]]

Attachment: recomposition_android_12.mp4

Lastly, for Android 12 it seems like the issue can be reproduced almost every time a rotation occurs.

Comment 8

[Vlad Dreghici [:vdreghici]]

Stopped focusing on this for now, since we are refactoring the homepage recycler view into being pure compose. Will keep an eye on it for now.