1841909 - Investigate the removal of the `configChanges` from the Android Manifest

Status: RESOLVED FIXED

(Fenix :: General, enhancement, P2)

Description

[Noah Bond [:007]]

After investigating Bug 1837446 and looking at Bug 1837498, there is a hypothesis that the config change flags in the manifest are causing some complex bugs. The config change flags may be causing the Composables to not properly recompose because those configuration change events are being ignored or manually handled.

As part of the work for this ticket, investigate removing these flags (at least from HomeActivity) and the work that would result from this, as there are a few areas of the app that override onConfigurationChanged such as TabsTrayFragment, FenixApplication, and OnboardingFragment.

After briefly discussing this with Jeff, it sounds like there was a historical reason for adding these flags that is no longer needed today.

For v1, remove the flags from the Debug manifest and let it bake for a period of time before removing them from the main manifest.

Comment 1

[Roger Yang [:royang]]

Not sure if it's related, but originally Fenix doesn't support landscape mode. This might be the remnant of our original behaviour that wasn't fully removed when we started supporting landscape mode.

Comment 2

[Matt Tighe [:matt-tighe]]

Patch from Sebastian that introduced this to Focus

Comment 3

[Noah Bond [:007]]

Closing this bug as this should no longer be an issue after Bug 1855519