1837659 - Consider instrumenting metrics configurations

Status: NEW

(Data Platform and Tools :: Glean: SDK, task, P4)

Description

[Chris H-C :chutten]

Metrics configurations can affect the completeness of data being reported, and it's not guaranteed to be clear which pings were subject to which configurations.

I propose we instrument metrics configurations and include the list of configured metrics in at least the "metrics" ping (maybe all pings the configured metrics are sent in + "metrics"?)

Comment 1

[Travis Long [:travis_]]

I approve of this, especially since it would give us something to compare to when validating behavior of remotely configured metrics.

Comment 2

[Travis Long [:travis_]]

Considering the limitations of LabeledBoolean metric type (this would not scale well with only 16 dynamic labels before we hit __other__), and considering this would imply some embedded encoding/format for a StringList metric type, I think that this might be a good use-case for the coming ObjectMetricType.

This ultimately is shaped as a list/array of key/value pairs and Object seems well suited for that shape of collection, and would scale better with wider adoption and use of Server Knobs. I propose to wait until the object type is ready for use and then use that for this collection.

Not only is it well shaped for this, this would potentially give us a way to have an integration/instrumentation test for the object metric type outside of the normal unit tests.

Comment 3

[Travis Long [:travis_]]

Untaking this until I have time to get back to it.