1837670 - Provide a per-addon UI to allow users to exempt specific extensions from the Quarantined Domains restrictions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to Bug 1834825, we plan to introduce in the about:addons card UI to allow the users to exempt specific extensions from the Quarantined Domains restrictions.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1837670 - Add to about:addons add-on card new UI to allow users to exempt specific extensions from the Quarantined Domains restrictions. r=willdurand,flod

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1837670 - Add role group and aria-label to the addon card detail view rows including input controls.

Before this patch:

• while navigating the addon card details page with the help of a screen reader,
  when one of the input controls included in the addon updates or private browsing row is
  reached, the screen reader will just read the label associated to the input controls, e.g.

  • once reached the "Allow automatic updates" radio buttons, the screen reader will read:

     "Default selected radio button"
    

  • then when moving the focus to the "Run in Private Windows" radio buttons,
    the screen reader will read:

     "Don't allow selected radio button"
    

  and in both cases it would be clear what "Default" or "Don't allow" is related to

After this patch:

• while navigating inside a row with the role set to group and an aria-label set to the
  same localized string used as the visible label for the group of controls, the screen reader will be
  also announce explicitly the group of controls being entered, which makes the label on the
  radio button much more clear than without it, e.g.

  • once reached the "Allow automatic updates" radio buttons, the screen reader will read

     "Allow automatic update panel, Default selected radio button"
    

  • then when moving the focus to the "Run in Private Windows" radio buttons,
    the screen reader will read:

     "Leaving panel, Run in Private Window panel, Don't allow selected radio button"
    

There is definitely more tweaks we may look into to improve screen readers behavior on the
about:addons addon cards further, but this seems a reasonable first step in the direction
of improving the accessibility on the addon card details rows that include input controls,
and reviews passes on this patch may also help us to collect more feedback related to
additional accessibility tweaks to cover in separate followups.

Depends on D181079

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1837670 - Add an hidden pref to disable the per-addon exemption indipendently from the quarantined domains feature. r?zombie!

Depends on D181079

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1837670 - Add new AddonWrapper 'quarantined domains'-related properties. r?zombie!,willdurand

Comment 5

[Phabricator Automation]

Comment on attachment 9340021 [details]
Bug 1837670 - Add new AddonWrapper 'quarantined domains'-related properties. r?zombie!,willdurand

Revision D181469 was moved to bug 1839393. Setting attachment 9340021 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9340021 [details]
Bug 1837670 - Add new AddonWrapper 'quarantined domains'-related properties. r?zombie!,willdurand

Revision D181469 was moved to bug 1839393. Setting attachment 9340021 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9339514 [details]
Bug 1837670 - Add role group and aria-label to the addon card detail view rows including input controls.

Revision D181220 was moved to bug 1839629. Setting attachment 9339514 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcf90cdf1100
Add to about:addons add-on card new UI to allow users to exempt specific extensions from the Quarantined Domains restrictions. r=willdurand,flod

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dcf90cdf1100

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out as requested by rpl.

Backout link: https://hg.mozilla.org/integration/autoland/rev/fa0f37e5c3dcc54aa90f657c2c06aa440bfe6dc1

Comment 11

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1837670 - Update extension button's quarantined domains warning messagebar to mention user controls for exempting specific extensions. r=willdurand,flod

Depends on D181079

Comment 12

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/fa0f37e5c3dc

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6310468a9643
Add to about:addons add-on card new UI to allow users to exempt specific extensions from the Quarantined Domains restrictions. r=willdurand,flod
https://hg.mozilla.org/integration/autoland/rev/aa25d8490f7a
Update extension button's quarantined domains warning messagebar to mention user controls for exempting specific extensions. r=willdurand,flod,fluent-reviewers

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6310468a9643
https://hg.mozilla.org/mozilla-central/rev/aa25d8490f7a