1837696 - Move preview shopping ftl file to locale directory in time for shipping

Status: RESOLVED FIXED

(Firefox Graveyard :: Shopping, task, P2)

Description

[:Gijs (he/him)]

Filing this early so we don't forget to do this before launch.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I don't think we actually need to enable localization for 119, since we're only targeting en-US. IIRC this was discussed with flod in a review, but I'll have to delve into phabricator history to find the link.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

What should we do with this bug? Close it? Kick it out to some future version?

Comment 3

[:Gijs (he/him)]

(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #2)

What should we do with this bug? Close it? Kick it out to some future version?

I'm not 100% sure. :flod, are Jared & I right that we don't actually need this to ship to US English only in 119? Does it serve any benefit to do it by 119?

Comment 4

[Francesco Lodolo [:flod]]

I think the question should be redirected to product. At some point, we still want to localize this, so it's not a wontfix.

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1837696 - Expose shopping strings to localization r?#shopping-reviewers

Note that some strings are still in the preview/shopping file, as we
don't yet have guidance on how to handle one of the brand names, so that
brand name and the strings that use that brand name are held back. These
will be addressed in followup bug 1849406.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a1bfa2c79cd
Expose shopping strings to localization r=shopping-reviewers,fluent-reviewers,flod,Gijs

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures on browser/components/shopping/tests/browser/browser_inprogress_analysis.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ac2e7950a08541424de2588bd0ae9ecdfc1c3a28

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_inprogress_analysis.js | Uncaught exception in test bound test_in_progress_analysis_stale

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e5768f3fc48
Expose shopping strings to localization r=shopping-reviewers,fluent-reviewers,flod,Gijs

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_inprogress_analysis.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f829a45e22076f02abeee8ca0f757a842da4f4de
Log link: https://treeherder.mozilla.org/logviewer?job_id=428182445&repo=autoland&lineNumber=22503

Please also check this bc failure on browser_shopping_integration.js

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b71ddb0547b1
Expose shopping strings to localization r=shopping-reviewers,fluent-reviewers,flod,Gijs

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b71ddb0547b1