Move preview shopping ftl file to locale directory in time for shipping
Categories
(Firefox :: Shopping, task, P2)
Tracking
()
People
(Reporter: Gijs, Assigned: jhirsch)
References
Details
(Whiteboard: [fidefe-shopping])
Attachments
(1 file)
Filing this early so we don't forget to do this before launch.
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
I don't think we actually need to enable localization for 119, since we're only targeting en-US. IIRC this was discussed with flod in a review, but I'll have to delve into phabricator history to find the link.
Assignee | ||
Comment 2•1 year ago
|
||
What should we do with this bug? Close it? Kick it out to some future version?
Reporter | ||
Comment 3•1 year ago
|
||
(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #2)
What should we do with this bug? Close it? Kick it out to some future version?
I'm not 100% sure. :flod, are Jared & I right that we don't actually need this to ship to US English only in 119? Does it serve any benefit to do it by 119?
Comment 4•1 year ago
|
||
I think the question should be redirected to product. At some point, we still want to localize this, so it's not a wontfix.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 5•1 year ago
|
||
Note that some strings are still in the preview/shopping file, as we
don't yet have guidance on how to handle one of the brand names, so that
brand name and the strings that use that brand name are held back. These
will be addressed in followup bug 1849406.
Comment 7•1 year ago
|
||
Backed out for causing bc failures on browser/components/shopping/tests/browser/browser_inprogress_analysis.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/ac2e7950a08541424de2588bd0ae9ecdfc1c3a28
Assignee | ||
Updated•1 year ago
|
Comment 9•1 year ago
•
|
||
Backed out for bc failure on browser_inprogress_analysis.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/f829a45e22076f02abeee8ca0f757a842da4f4de
Log link: https://treeherder.mozilla.org/logviewer?job_id=428182445&repo=autoland&lineNumber=22503
Please also check this bc failure on browser_shopping_integration.js
Comment 10•1 year ago
|
||
Assignee | ||
Updated•1 year ago
|
Comment 11•1 year ago
|
||
bugherder |
Updated•1 year ago
|
Description
•