1837931 - Last character is removed unexpectedly when using newer GBoard

Status: RESOLVED FIXED

(GeckoView :: IME, defect, P2)

Description

[Makoto Kato [:m_kato]]

When using Japanese keyboard of GBoard, is is possible to convert "かっこ" with "()" from candidate list. But when using new GBoard beta?, GeckoView will insert "(" instead of "()".

When tracing API calls, GBoard does't insert "()" simply.

1. inputConnection.beginBatchEdit()
2. inputConnection.commit("( ", 1)
3. inputConnection.commit(")", -1)
4. inputConnection.deleteSurroundingText(0, 1)
5. inputConnection.endiBatchEdit()

So we need to support this strange steps.

Comment 1

[Makoto Kato [:m_kato]]

Since GBoard doesn't always use this steps to insert "()", I don't know the trigger when this occurs. Most situation uses commitText("()", 1) only.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1837931 - text isn't inserted at correct position when calling commitText several times. r=#geckoview-reviewers!

When calling InputConnection.commitText multiple times into batch
mode, Gecko may sometime set incorrect selection (caret) position.

Although Gecko's text handling is that text change will also update
selection, Android doesn't want it. But commitText's implementation is
the following

1. Update selection
2. Update text
3. Update selection

Gecko doesn't want 1.'s selection change before changing text. So I
would like to remove 1's to fit with Gecko's text handling.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4e511378623
text isn't inserted at correct position when calling commitText several times. r=geckoview-reviewers,owlish

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b4e511378623