1889508 - Crash in [@ java.lang.reflect.UndeclaredThrowableException: at $Proxy15.replace(Unknown Source)]

Status: VERIFIED FIXED

(GeckoView :: IME, defect)

Description

[Makoto Kato [:m_kato]]

Crash report: https://crash-stats.mozilla.org/report/index/c31dc8d6-16f2-4299-a086-fcd7a0240325

Java stack trace:

java.lang.reflect.UndeclaredThrowableException
	at $Proxy15.replace(Unknown Source)
	at org.mozilla.geckoview.GeckoInputConnection.commitText(GeckoInputConnection.java:79)
	at com.android.internal.view.IInputConnectionWrapper.executeMessage(IInputConnectionWrapper.java:286)
	at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage(IInputConnectionWrapper.java:78)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:148)
	at org.mozilla.geckoview.GeckoInputConnection$9.run(GeckoInputConnection.java:21)
	at java.lang.Thread.run(Thread.java:818)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1889508 - Don't override InputConnection.commitText on Samsung Galaxy J7. r=#geckoview-reviewers

It seems to occur unexpected crash on Android 6 with Samsung Galaxy J7
only.

I don't know why Editable.replace throws null pointer exception. As long
as AOSP code, there is no reason to throw it. I guess this causes Samsung's
customizations etc.

So I would like to turn off the optimization by bug 1837931 on Galaxy J7
only.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1837931

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on beta

For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2168f88afb52
Don't override InputConnection.commitText on Samsung Galaxy J7. r=geckoview-reviewers,ohall

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 9394906 [details]
Bug 1889508 - Don't override InputConnection.commitText on Samsung Galaxy J7. r=#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: According to crash reporter, after landing bug 1837931, Firefox will crash on Samsung Galaxy J7 (Android 6 only) when inputting a text.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: If QA has Galaxy J7 with Android 6, please test when input text in HTML form.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Disable bug 1837931's fix (This is an optimization for text input) on Samsung Galaxy J7 (Android 6).
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2168f88afb52

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9394906 [details]
Bug 1889508 - Don't override InputConnection.commitText on Samsung Galaxy J7. r=#geckoview-reviewers

Approved for 125.0rc1. If we still see the crashes, let's backout.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f73fb68140e3

Comment 9

[Vasilica Tamas QA [:vtamas]]

Unfortunately the QA team doesn't possess a Samsung Galaxy J7 with Android 6 but we tested this issue on 2 Samsung devices with nearest Android versions. The crash was not encountered on Firefox Nightly 126 (2024-04-08) and Firefox 125 Beta 9 under Samsung Galaxy S9 (Android 8) and Samsung Galaxy Tab A T285 (Android 5.1.1). Based on this testing I'm marking this bug as Verified.