1837939 - update-packaging: basename: extra operand ‘Media’

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Julien Cristau [:jcristau]]

https://treeherder.mozilla.org/logviewer?job_id=418848929&repo=mozilla-central&lineNumber=451

[task 2023-06-10T23:35:58.758Z] 23:35:58     INFO -          add "Contents/MacOS/media-plugin-helper.app/Contents/_CodeSignature/CodeResources"
[task 2023-06-10T23:35:58.785Z] 23:35:58     INFO -  basename: extra operand ‘Media’
[task 2023-06-10T23:35:58.785Z] 23:35:58     INFO -  Try 'basename --help' for more information.
[task 2023-06-10T23:35:58.788Z] 23:35:58     INFO -  basename: extra operand ‘Media’
[task 2023-06-10T23:35:58.788Z] 23:35:58     INFO -  Try 'basename --help' for more information.
[task 2023-06-10T23:35:58.789Z] 23:35:58     INFO -  /builds/worker/checkouts/gecko/tools/update-packaging/common.sh: line 95: [: too many arguments
[task 2023-06-10T23:35:58.795Z] 23:35:58     INFO -          add "Contents/MacOS/media-plugin-helper.app/Contents/Resources/Firefox Nightly Media Plugin Helper.sig"
[task 2023-06-10T23:35:58.835Z] 23:35:58     INFO -          add "Contents/MacOS/media-plugin-helper.app/Contents/Resources/English.lproj/InfoPlist.strings"
[task 2023-06-10T23:35:58.864Z] 23:35:58     INFO -          add "Contents/MacOS/media-plugin-helper.app/Contents/PkgInfo"
[task 2023-06-10T23:35:58.879Z] 23:35:58     INFO -  basename: extra operand ‘Media’
[task 2023-06-10T23:35:58.879Z] 23:35:58     INFO -  Try 'basename --help' for more information.
[task 2023-06-10T23:35:58.882Z] 23:35:58     INFO -  basename: extra operand ‘Media’
[task 2023-06-10T23:35:58.882Z] 23:35:58     INFO -  Try 'basename --help' for more information.
[task 2023-06-10T23:35:58.883Z] 23:35:58     INFO -  /builds/worker/checkouts/gecko/tools/update-packaging/common.sh: line 95: [: too many arguments
[task 2023-06-10T23:35:58.889Z] 23:35:58     INFO -          add "Contents/MacOS/media-plugin-helper.app/Contents/MacOS/Firefox Nightly Media Plugin Helper"

Comment 1

[Julien Cristau [:jcristau]]

Attachment: Bug 1837939 - update-packaging: quote filenames that can contain spaces. r?#releng

Bug 1837329 added a new "Media Plugin Helper" that caused errors in repack logs
(though as far as I can tell had no effect on the mar files themselves).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c363ce943d91
update-packaging: quote filenames that can contain spaces. r=releng-reviewers,bhearsum DONTBUILD

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c363ce943d91