1837986 - [Tabs tray to Compose] The normal browsing number of opened tabs has visual defects

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, defect)

Description

[Delia Pop (Android QA)]

Attachment: The normal browsing number of opened tabs is incorrectly displayed.jpg

Prerequisites

1. Install and launch the latest Nightly 116.0a1 from 06/08.
2. Enable the “Enable Tabs Tray to Compose rewrite” toggle from Secret Settings.

Steps to reproduce

1. Open at least one tab in normal browsing mode.
2. Open the tabs tray.
3. Select the private tabs view.
4. Observe the normal browsing number of opened tabs icon.

Expected behavior

The normal browsing number of opened tabs icon is displayed without visual defects.

Actual behavior

On tablet devices, the number of opened tabs is displayed off-center towards the bottom of the square icon.
On both tablet & phone devices, the number of opened tabs is displayed highlighted (in a brighter color that the square icon.

Device information

• Firefox version: Nightly 116.0a1 from 06/09
• Android devices: Lenovo tab M10 (Android 10), Xiaomi Redmi Note 8T (Android 11), Samsung Galaxy A53 5G (Android 13), Lenovo Yoga Tab 11 (Android 11) .

Any additional information?

• NOT reproducible if the "Tabs Tray to Compose rewrite" option from Secret Settings is disabled.
• Not reproducible on latest Beta 115.0b2 and RC 114.0 build 3, where the number of opened tabs is centered and greyedout.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1837986 - add the right color to the number of the normal tabs in tabs tray (#2647)

Comment 2

[Noah Bond [:007]]

The text alignment bug is also documented in Bug 1836352

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1837986 - add the right color and alignment to the number of the normal tabs in compose tabs tray (#2677)

Comment 4

[BMO Github Automation]

Authored by https://github.com/Alexandra-Virvara
https://github.com/mozilla-mobile/firefox-android/commit/3357be93c3324b68dc2a9879d77d31802c05a931
[main] Bug 1837986 - the number of the normal tabs has visual defects

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:avirvara, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Alexandra Virvara]

no need to uplift it for now as the fix requires TabsTray to Compose being enabled

Comment 7

[Delia Pop (Android QA)]

Attachment: 1837986.png

Verified as fixed on latest Nightly 117.0a1 from 07/07. The number of opened tabs is now displayed centered and no longer highlighted.
However, https://bugzilla.mozilla.org/show_bug.cgi?id=1842223 was reported as a regression, where the number of opened tabs is displayed highlighted in the light/dark purple color (according to the selected theme) for a split second, then is updated to match the square icon color (white).
Devices used:

• Lenovo Yoga Tab 11 (Android 11)
• Samsung Galaxy Tab A7 (Android 13)