1842223 - [Tabs tray to Compose] The normal browsing number of opened tabs has a color flicker

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, defect, P3)

Description

[Delia Pop (Android QA)]

Attachment: color flicker.mp4

Prerequisites

1. Install and launch the latest Nightly 117.0a1 from 07/07.
2. Enable the “Enable Tabs Tray to Compose rewrite” toggle from Secret Settings.

Steps to reproduce

1. Open at least one tab in normal browsing mode.
2. Open the tabs tray.
3. Select the private tabs view.
4. Select the normal tabs view and observe the normal browsing number of opened tabs icon.

Expected behavior

When selecting the normal tabs view, the number of opened tabs and the square icon around it are displayed in the white color at the same time.

Actual behavior

When selecting the normal tabs view, the number of opened tabs is displayed highlighted in the light/dark purple color (according to the selected theme) for a split second, then is updated to match the square icon color (white).

Device information

• Firefox version: Nightly 117.0a1 from 07/07
• Android devices: Samsung Galaxy A53 5G (Android 13), Lenovo Yoga Tab 11 (Android 11) (all devices).

Any additional information?

• NOT reproducible if the "Tabs Tray to Compose rewrite" option from Secret Settings is disabled.
• Not reproducible before the fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1837986 landed.

Comment 1

[Delia Pop (Android QA)]

Hi, :Alexandra, this issue seems to be a regression after https://bugzilla.mozilla.org/show_bug.cgi?id=1837986. Can you please take a look? Thank you!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1837986

Comment 3

[Noah Bond [:007]]

It looks like the text is getting colored before the rest of the icon. If I had to guess, we likely need to use the LocalContentColor.current on the text color, so it uses the same under the hood color logic that changes the tints of the tab page icons, instead of having a boolean drive the color flip.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1842223 - the color of normal open tabs has a flicker (#2791)

Comment 5

[BMO Github Automation]

Authored by https://github.com/Alexandra-Virvara
https://github.com/mozilla-mobile/firefox-android/commit/86ecad2ff3bf2f7cbaeeaa1c894bd991ea6fce09
[main] Bug 1842223 - the color of normal open tabs has a flicker

Comment 6

[Lorand Janos]

Managed to reproduce this issue on an earlier Nightly build (117.0a1 from 2023-07-13).
Verified as fixed on the latest Nightly build (117.0a1 from 2023-07-18).
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified.

Comment 7

[Lorand Janos]

Attachment: az_recorder_20230718_103017.mp4