1838190 - Feed folders don't get site favicon for feeds where there is no site favicon.ico and the page doesn't specify an icon

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Upstream communication]

+++ This bug was initially created as a clone of Bug #1824272 +++

Bug 1824272 didn't fix this reliably. Most notably, the favicon is missing for
https://hg.mozilla.org/mozilla-central/pushlog

There are others, too, like: https://follow.it/der-postillon-abo?user=xxx (needs a subscription).

Comment 1

[Magnus Melin [:mkmelin]]

I see this for certain pages. If there is no favicon.ico in the root and the page doesn't specify an icon either, we won't find one.
All the callbacks in 102 makes that code very hard to read but it looks like we should also check the index page of the site and use that icon when other means fail.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1838190 - Discover feed icon at site index page as well. r=#thunderbird-reviewers

Comment 3

[Upstream communication]

With this change, the two feeds mentioned in comment #0 receive their icon now, however, another subscription service is still without icon. Or has the default icon changed from a folder with "RSS corner" seen in 102 to a globe seen in 115?

Comment 4

[Magnus Melin [:mkmelin]]

The globe is the "fallback" when no icon was found. The default folder icon is not specific to rss accounts.

I'd need the URL to investigate what the problem would be for other services.

Comment 5

[Upstream communication]

Thanks. This RSS is private. We'll file a new bug if we come across another non-functioning one that can be published (or other users will beat us to it). Or is there any more specific information we can supply?

Comment 6

[Magnus Melin [:mkmelin]]

It's basically looking in the dev tools for which URLs are tried for a Get Messages on the feed. Then check if the pages actually have information discoverFaviconURL will accept.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ea37ce752b97
Discover feed icon at site index page as well. r=freaktechnik

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9339201 [details]
Bug 1838190 - Discover feed icon at site index page as well. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: won't always get favicon for feeds
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9339201 [details]
Bug 1838190 - Discover feed icon at site index page as well. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/ae39abe576b5