1838259 - CacheAPI PBM support: Enable wpt tests to run on private and regular mode.

Status: RESOLVED FIXED

(Core :: Storage: Cache API, task, P3)

Description

[Harveer Singh]

We should enable wpt tests to run on both regular and private mode.

Comment 1

[Harveer Singh]

Attachment: Bug 1838259: Run Cache-API wpt tests in private browsing mode.r=#dom-storage-reviewers

Comment 2

[Harveer Singh]

I have created a new wpt test type 'web-platform-tests-privatebrowsing' https://phabricator.services.mozilla.com/D170069 which would only run the wpt tests tagged with 'privatebrowsing'. Similar to IndexedDB, I don't see a dedicated tests directory under testing/web-platform/tests/* for Cache API. But, I do see some cache API tests under testing/web-platform/tests/storage/* and testing/web-platform/tests/service-workers/cache-storage/*.

So as part of this work, I tagged all tests under above mentioned paths to be run under new wpt test-type 'web-platform-tests-privatebrowsing'. I see that we have some wpt tests especially the ones which are named '*.any.js' also getting run under a 'worker', 'sharedworker' and a 'service-worker'. Tests like these are failing are failing when running under a service worker because service worker is not yet supported in private browsing mode. I would need to explicitly disable such tests under privatebrowsing run.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7507533a8488
Run Cache-API wpt tests in private browsing mode.r=taskgraph-reviewers,dom-storage-reviewers,jmaher,jgraham,janv

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43109 for changes under testing/web-platform/tests

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7507533a8488

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90a7360e30b5
[wpt PR 43109] - [Gecko Bug 1838259] Run Cache-API wpt tests in private browsing mode., a=testonly

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ae2aa2ef363
[wpt PR 43109] - [Gecko Bug 1838259] Run Cache-API wpt tests in private browsing mode., a=testonly

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0ae2aa2ef363