Temporarily disable misc-include-cleaner
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(firefox116 fixed)
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
Details
Attachments
(1 file)
For the time being we need to disable misc-include-cleaner during review-phase. The current situation will be addressed once code-review bot will run in before and after method.
|
Assignee | |
Comment 1•1 year ago
|
||
|
|
Assignee | |
Updated•1 year ago
|
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
|
||
Comment 4•1 year ago
|
||
Is this actually disabled or is there some further deploy step needed? This bot just dumped a bunch of useless warnings on a patch 20 minutes ago. Thanks.
|
||
Comment 5•1 year ago
|
||
I also am seeing it say things in https://phabricator.services.mozilla.com/D181516 from a patch today and https://hg.mozilla.org/mozilla-central/log/tip/tools/clang-tidy/config.yaml isn't suggesting it's been re-enabled.
|
|
Assignee | |
Comment 6•1 year ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #4)
Is this actually disabled or is there some further deploy step needed? This bot just dumped a bunch of useless warnings on a patch 20 minutes ago. Thanks.
the base revision on that diff wasn't based on mozilla-central that had this patch committed.
|
|
Assignee | |
Comment 7•1 year ago
|
||
(In reply to Andrew Sutherland [:asuth] (he/him) (back July 10th) from comment #5)
I also am seeing it say things in https://phabricator.services.mozilla.com/D181516 from a patch today and https://hg.mozilla.org/mozilla-central/log/tip/tools/clang-tidy/config.yaml isn't suggesting it's been re-enabled.
It's the same case here as above: https://hg.mozilla.org/try/file/cd0f814855439bcb988d4221e44d358a3498c5d0/tools/clang-tidy/config.yaml#l137 whereas this is how m-c looks like https://hg.mozilla.org/mozilla-central/file/tip/tools/clang-tidy/config.yaml#l137
Description
•