1836676 - Re-enable include cleaner as clang-tidy checker

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Andi [:andi]]

As we moved to newer versions of clang we had to disable the implementation of include-cleaner since it was no longer compatible with clang-16 [1]
Now, there is a new version in clang-trunk that is officially accepted [2].

The goal of these patches is to backport the official include cleaner from clang-trunk to our own version of clang, 16.0.X and to have it activated in our config files to run during review phase using code-review bot.

1 - https://phabricator.services.mozilla.com/D173106
2 - https://github.com/llvm/llvm-project/commit/c28506ba4b6961950849f8fdecd0cf7e503a14f9

Comment 1

[Andi [:andi]]

Let's see that we've nailed this one https://treeherder.mozilla.org/jobs?repo=try&revision=886c3fc9e5ddf7beac22afd71db05590f872883f.

Comment 2

[Andi [:andi]]

Attachment: Bug 1836676 - Backport misc-include-cleaner from clang-trunk to clang-16.

Comment 3

[Andi [:andi]]

Attachment: Bug 1836676 - for clang-tidy activate mis-include-cleaner.

Depends on D179889

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bc48e13c29d
Backport misc-include-cleaner from clang-trunk to clang-16. r=sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/1318d220baed
for clang-tidy activate mis-include-cleaner. r=sergesanspaille

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1bc48e13c29d
https://hg.mozilla.org/mozilla-central/rev/1318d220baed

Comment 6

[Kelsey Gilbert [:jgilbert]]

This lint is very noisy in phabricator, and interferes with reviewing code, and adding includes such as RefPtr everywhere doesn't seem like what we want.

In this patch, there are three warnings on just this one line, and two of them are for RefPtr: https://phabricator.services.mozilla.com/D180456#C6543866NL358

Comment 7

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Similarly, I rebased my patches in Bug 1529131 today and I was surprised by the amount of clang-tidy warnings I got. I agree that it makes it harder to see what's happening.