1838507 - [about:welcome] Optimize New User Onboarding New Import experience in Fx115

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement)

Description

[Punam Dahiya [:pdahiya]]

With fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1837009 in Fx115, 'browser.migrate.content-modal.enabled' as true
'browser.migrate.content-modal.about-welcome-behavior' as default
'browser.migrate.content-modal.import-all.enabled' as true

new user onboarding import flow will take user away to about:preferences impacting onboarding completion rate. This is treatment-d branch experience from new import interface experiment in Fx113

https://experimenter.services.mozilla.com/nimbus/new-import-interface-firefox-113/summary

Scope of this bug is to track if we would like to use autoclose or any other option for import flow opened via about:welcome in Fx115.

With Fx116 , we are actively looking into Embedded Import Wizard experience in about:welcome

Experiment in Fx114
https://experimenter.services.mozilla.com/nimbus/embedded-import-wizard/summary

Feature implementation in Fx116
https://mozilla-hub.atlassian.net/browse/OMC-449

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1838507 - Default the about:welcome migration behaviour to the legacy XUL dialog. r?Mardak!

This adds a new behaviour that opens the legacy migration wizard from about:welcome,
and sets the pref to default to that behaviour.

This also adds the behaviour to the FeatureManifest.yaml file so that it can be
instrumented remotely via Nimbus.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c1c9f4c2dd4
Default the about:welcome migration behaviour to the legacy XUL dialog. r=Mardak

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9c1c9f4c2dd4

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9339320 [details]
Bug 1838507 - Default the about:welcome migration behaviour to the legacy XUL dialog. r?Mardak!

Beta/Release Uplift Approval Request

• User impact if declined: Users on Firefox 115+ will see some variant of the new migration wizard when launched from about:welcome, and we're not fully confident on which variant of the new migration wizard we want to show yet, so we'd prefer to fallback to the legacy one.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Set browser.migrate.content-modal.about-welcome-behavior to legacy

2. Browse to about:welcome
3. Skip forward to the slide that exposes a button for importing browser data
4. Click the button

ER: The old legacy XUL migration wizard should appear

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Covered by automated tests. Fairly small change that just adds a special condition for the about:welcome entrypoint for the migration wizard.
• String changes made/needed: None.
• Is Android affected?: No

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9339320 [details]
Bug 1838507 - Default the about:welcome migration behaviour to the legacy XUL dialog. r?Mardak!

Approved for 115.0b7.

Comment 6

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/949c58f967f9

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1838507 - Follow-up: make sure to use the legacy migration wizard for startup migrations on beta.

This condition was removed in bug 1823537 for central, but on beta we
still need it because the legacy migration wizard is still being used
for startup migrations there.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: WIP: Bug 1838507 - Follow-up: make sure to use the legacy migration wizard for startup migrations on beta.

This condition was removed in bug 1823537 for central, but on beta we
still need it because the legacy migration wizard is still being used
for startup migrations there.

Comment 9

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2d70dba8bc4f

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the latest Firefox Nightly 116.0a1 (Build ID: 20230619093216) and Firefox Beta 115.0b7 (Build ID: 20230618180218) installed on Windows 10 x64 and macOS 13.2. I can confirm the following:

• The browser.migrate.content-modal.about-welcome-behavior pref is set to legacy by default in the "about:config" page.
• The old legacy Import wizard is triggered from the "Import" Onboarding screen.
• No data is imported if the Import wizard is closed.
• No data is imported if the Import flow is canceled.
• Data is successfully imported if the import flow is finalized.
• I have verified that the new Import wizard is displayed and the "about:preferences" page is closed after the import flow is completed if the browser.migrate.content-modal.about-welcome-behavior pref is set to autoclose
• Also I have verified that the old legacy Import wizard is triggered from the "Import" Onboarding screen on Ubuntu 22.04 x64.