Closed Bug 1838520 Opened 2 years ago Closed 2 years ago

filter field in quick filter bar is not cleared when switching the folder

Categories

(Thunderbird :: Folder and Message Lists, defect)

Thunderbird 116
defect

Tracking

(thunderbird_esr102 unaffected, thunderbird115 fixed, thunderbird116 affected)

RESOLVED FIXED
116 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird115 --- fixed
thunderbird116 --- affected

People

(Reporter: soeren.hentzschel, Assigned: darktrojan)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  1. Make sure that the quick filter bar is enabled and that the option to keep the filter criteria when switching folders is not enabled
  2. Enter something into the text field of the quick filter bar
  3. Switch the folder

Actual:

The input field still contains the previously entered text but since the filter is no longer active it's very confusing.

Expected:

The input field should be empty, as it was the case in Thunderbird 102.

Summary: filter field in quick filter bar is not emptied when switching folder → filter field in quick filter bar is not cleared when switching the folder
Regressed by: 1820423
Assignee: nobody → geoff
Status: NEW → ASSIGNED

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/38c2283d43c1
Clear quickFilterBar.activeElement if the displayed folder changes. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

I backed this out, because it wasn't actually reviewed. I mixed it up with another patch that was meant to land.
https://hg.mozilla.org/comm-central/rev/8435ea7897e392541d9712c8b1888772d961fda6

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: --- → 116 Branch

Pushed by elizabeth@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/ba2ef53fe94c
Clear quickFilterBar.activeElement if the displayed folder changes. r=mkmelin

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED

Comment on attachment 9339211 [details]
Bug 1838520 - Clear quickFilterBar.activeElement if the displayed folder changes. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1820423
User impact if declined: quick filter text field retains filter string although it's not used
Testing completed (on c-c, etc.): landed 2 days ago
Risk to taking this patch (and alternatives if risky): low

Attachment #9339211 - Flags: approval-comm-beta?

Comment on attachment 9339211 [details]
Bug 1838520 - Clear quickFilterBar.activeElement if the displayed folder changes. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9339211 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: