1838549 - Sync now button is blank in Settings -> Sync

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Sammy Khamis [:skhamis]]

Attachment: Screenshot 2023-06-14 at 1.48.13 PM.png

The sync now button is blank and only turns into "Sync now" after pressing the button and completing a sync or any other sync-based updates.

However every time the page is refreshed it shows back up blank.

Comment 1

[Sammy Khamis [:skhamis]]

from mozregression

2023-06-14T13:35:38.368000: INFO : Narrowed integration regression window from [20056e07, f0bb54e0] (3 builds) to [e888855e, f0bb54e0] (2 builds) (~1 steps left)
2023-06-14T13:35:38.376000: DEBUG : Starting merge handling...
2023-06-14T13:35:38.376000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=f0bb54e03054060649af1c6d5025c09c4e85ebf2&full=1
2023-06-14T13:35:38.376000: DEBUG : redo: attempt 1/3
2023-06-14T13:35:38.376000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=f0bb54e03054060649af1c6d5025c09c4e85ebf2&full=1',), kwargs: {}, attempt #1
2023-06-14T13:35:38.478000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2023-06-14T13:35:39.275000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=f0bb54e03054060649af1c6d5025c09c4e85ebf2&full=1 HTTP/1.1" 200 None
2023-06-14T13:35:39.315000: DEBUG : Found commit message:
Bug 1831259 - prevent initialization re-entrancy for preference panes, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D178232

2023-06-14T13:35:39.316000: DEBUG : Did not find a branch, checking all integration branches
2023-06-14T13:35:39.320000: INFO : The bisection is done.
2023-06-14T13:35:39.321000: INFO : Stopped

and confirmed by reversing the changes in the diff that the "Sync now" button comes back. Gijs, any idea why this might've been caused by that patch?

From everything we've looked at https://searchfox.org/mozilla-central/source/browser/components/preferences/sync.js#308-311 labelnotsyncing does not seem to be being set on first loading the page but is there on any subsequent calls.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1831259

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Sammy Khamis [:skhamis] from comment #1)

From everything we've looked at https://searchfox.org/mozilla-central/source/browser/components/preferences/sync.js#308-311 labelnotsyncing does not seem to be being set on first loading the page but is there on any subsequent calls.

Generally speaking, you cannot depend on fluent putting labels on elements synchronously.

The regressing patch changed some logic that was forcing this to be the case for pref pane initialization, in order to improve performance and make it simpler to avoid re-entrancy (pane initialization being called multiple times, which could potentially already cause this issue to appear).

It looks to me like the right solution is probably to make _updateSyncNow just set a data-l10n-id on the button that has the right string, instead of having 1 fluent identifier that then sets 4 different properties, ie to split https://searchfox.org/mozilla-central/rev/1d43d9f3d0ffcbdb619cfd1e2911fb22d1456657/browser/locales/en-US/browser/preferences/preferences.ftl#895-898 .

I can take this, seeing as I broke it.

Comment 4

[:Gijs (out for now; he/him)]

Attachment: Bug 1838549 - fix sync now button label disappearing by using separate fluent strings for both states, r?skhamis,markh

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fa5403a47ee
fix sync now button label disappearing by using separate fluent strings for both states, r=markh,fluent-reviewers,flod,mconley

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8fa5403a47ee

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1831259

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-06-14 Nightly build on Windows 10.
Verified as fixed on Firefox 116.0b5(build ID: 20230713175905) and Nightly 117.0a1(build ID: 20230713214846) on Windows 10, macOS 12, Ubuntu 22.
Sync button is no longer blank.