1838658 - Fix failing WPT canvas test 2d.text.font.parse.complex.html

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jonathan Kew [:jfkthame]]

We currently fail the test /html/canvas/element/text-styles/2d.text.font.parse.complex.html because it expects the font family name Unknown Font to be quoted when the font attribute is re-serialized. However, the quotes are optional on such a name. So we should make the test accept either quoted or unquoted forms.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1838658 - patch 2 - Make family-name quotes optional in 2d.text.font.parse.complex test, and add a further test where quotes are required. r=#gfx-reviewers

Comment 2

[Jonathan Kew [:jfkthame]]

Hmm, correcting this test so that we'd expect to pass it revealed a separate bug in our offscreen-canvas impl: we ignore small-caps if it is present in the value of the font attribute. Adding a patch to fix that.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1838658 - patch 1 - Handle the 'small-caps' variant when OffscreenCanvas is parsing and serializing the 'font' attribute. r=#gfx-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55e098bcfd58
patch 1 - Handle the 'small-caps' variant when OffscreenCanvas is parsing and serializing the 'font' attribute. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/726c909740bf
patch 2 - Make family-name quotes optional in 2d.text.font.parse.complex test, and add a further test where quotes are required. r=gfx-reviewers,lsalzman

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40587 for changes under testing/web-platform/tests

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/55e098bcfd58
https://hg.mozilla.org/mozilla-central/rev/726c909740bf

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot