1838672 - unified folders doesn't show spam folder

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[dquiros]

Steps to reproduce:

Open TB with Unified Folders.

Actual results:

unified folders dont show spam folder.

Expected results:

unified folders should show spam folder with accounts in it. Like the trash folder.

Comment 1

[Magnus Melin [:mkmelin]]

Hmm, I see just one Junk (not expansible even if I have many accounts with Junk - some with localized names).
Code should be somewhere around here: https://searchfox.org/comm-central/rev/0a8a9a51ec7ff330d93ac06b6fe02f4e95be57e1/mail/base/content/about3Pane.js#780

Comment 2

[Wayne Mery (:wsmwk)]

Are you still seeing this issue with 116?

Comment 3

[dquiros]

yes

Comment 4

[Frank]

Hi! I am affected as well (115.0.1). I also see IMAP "Junk" folders showing up in unified folders but not "Spam" folders. This is a consistent false behaviours though all my accounts and it was different before v115 where all such folders (Junk and Spam) were grouped in the same way.

Comment 6

[yosukematsumura]

Affected in TB 115.1.0

Comment 7

[dquiros]

TB 117.0b1

Comment 8

[dquiros]

it should be dont as folders is plural.

Comment 9

[yosukematsumura]

This is far from ideal, but I was able to "fix" this issue by wiping out my accounts and profile and setting up my mail accounts from scratch. Even then, it took a couple tries before it got it right. Seems like it's more likely to work if you don't engage the Unified Folder view until after you've set up all of your mail accounts first (and made sure all your folder settings are correct for each account).

Comment 10

[dquiros]

so if you use unified accounts and add another account it breaks again and have to start over?

Comment 11

[yosukematsumura]

Admittedly I did not test rigorously. What I experienced was only:

Set up Account 1 > Switch to Unified > Set up Account 2 => broken
Set up Account 1 > Set up Account 2 > Switch to Unified => works

Beyond that I haven't experimented or anything more. It's working for me for now and I don't want to mess it up again.

Comment 12

[dquiros]

I get your point, I would be scared as well.

what if you have 10 accounts? 100?

it is a bug.

Comment 13

[Geoff Lankow (:darktrojan)]

(In reply to yosukematsumura from comment #9)

Seems like it's more likely to work if you don't engage the Unified Folder view until after you've set up all of your mail accounts first (and made sure all your folder settings are correct for each account).

I can see a problem which would cause accounts added after Unified Folders is turned on to not have their Spam/Junk folder added to the unified Spam folder. That is probably the cause of this bug and bug 1845544.

This is far from ideal, but I was able to "fix" this issue by wiping out my accounts and profile and setting up my mail accounts from scratch. Even then, it took a couple tries before it got it right.

If you right-click on the unified folder and click on Properties, you can choose the folders that the unified folder looks in.

Comment 14

[dquiros]

"If you right-click on the unified folder and click on Properties, you can choose the folders that the unified folder looks in."

Good call!

Some of my accounts have junk and spam folders, some only one of them, some none. I can select them all and hopefully get all SPAM emails in the Junk Unified Folder.

It is a shame I cant Rename that Unified Folder to SPAM or whatever I want. It seems it reads it and creates the name for you and cant be changed.

A request to be able to change the name?

Comment 15

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1838672 - Add junk folders to the unified junk folder when they get created. r=mkmelin

We've just been ignoring junk folders in this function until now.

Comment 16

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1838672 - Ensure a virtual folder's searched folders exist when filling the folder tree. r=aleca

A virtual folder can be modified during an OnFolderAdded notification, but the (real) added folder
may not yet exist in the folder lookup service. When the folder tree is notified of the virtual
folder change, it asks the folder lookup service for the folders, so they need to exist.

Depends on D185973

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bd72160cab8d
Add junk folders to the unified junk folder when they get created. r=mkmelin
https://hg.mozilla.org/comm-central/rev/615ee9c6ec34
Ensure a virtual folder's searched folders exist when filling the folder tree. r=aleca

Comment 18

[Geoff Lankow (:darktrojan)]

Comment on attachment 9348509 [details]
Bug 1838672 - Add junk folders to the unified junk folder when they get created. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: folders from new accounts might not get added to unified folders
Testing completed (on c-c, etc.): in 118 beta 1
Risk to taking this patch (and alternatives if risky): low

(both patches)

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9348509 [details]
Bug 1838672 - Add junk folders to the unified junk folder when they get created. r=mkmelin

[Triage Comment]
Approved for esr115

Comment 20

[Wayne Mery (:wsmwk)]

Comment on attachment 9348510 [details]
Bug 1838672 - Ensure a virtual folder's searched folders exist when filling the folder tree. r=aleca

[Triage Comment]
Approved for esr115

Comment 21

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.1:
https://hg.mozilla.org/releases/comm-esr115/rev/844b7a76bf6c
https://hg.mozilla.org/releases/comm-esr115/rev/1d3e163f6d02