1838871 - Ctrl-Shift-T no longer re-opens the last closed tab after restarting the browser

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Paraphrasing bug 1833416 comment 4:

After bug 1833416 landed, when Firefox is open Ctrl+Shift+T does not open closed tabs I have from last session

Step to reproduce:

1. set Firefox to 'Open previous windows and tabs'
2. on one open window open and close some tabs
3. close Firefox
4. open Firefox
5. click Ctrl+Shift+T to open last closed tab

Result: no tab open

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey dao, what do you think we should do in this case? Perhaps if the list of closing actions is empty, we fallback to the previous behaviour of opening the most recently closed tab (and if no such tab exists, trying to re-open the last session?)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1833416

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I spoke to epang about this, and he agreed this is the right move.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1838871 - Fallback to previous behaviour of Ctrl-Shift-T if the in-memory undo actions list is empty. r?dao!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8fcfbd2c5e9
Fallback to previous behaviour of Ctrl-Shift-T if the in-memory undo actions list is empty. r=dao,sessionstore-reviewers

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58c6c7c676e3
Backed out changeset b8fcfbd2c5e9 for causing failures at browser_restoreLastClosedTabOrWindowOrSession.js. CLOSED TREE

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_restoreLastClosedTabOrWindowOrSession.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/58c6c7c676e39b2e205382edb8cfde5169edd916

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b8fcfbd2c5e9348487e7f3da024507694cbe8a6f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=419649836&repo=autoland&lineNumber=21461

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f216a0434428
Fallback to previous behaviour of Ctrl-Shift-T if the in-memory undo actions list is empty. r=dao,sessionstore-reviewers

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f216a0434428

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1833416

Comment 11

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 116.0a1 (2023-06-16) on MacOS 12 (command+shift+t) and Win 10 (ctrl+shift+t).
The issue is verified fixed with Firefox 117.0a1 (20230724091621) and Firefox 116.0b8 (20230720200012) on MacOS 12, Win 10 and Ubuntu 22.