1833416 - Change keyboard shortcut to act as a general 'undo' for last closed tab, window or session

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement)

Description

[Sarah Clements [:sclements]]

During work on bug 1820660, I discovered that mconley had modified the Ctrl|Cmd + shift + T keyboard shortcut to restore the last session if there aren't any closed tabs to restore, per bug 1423125. However, this will not work as intended if the changes in bug 1820660 land, since it persists close tabs between sessions.

I spoke with epang about this, and he suggested we change the keyboard shortcut logic to act as a general undo, so per our slack convo:

Ctrl/Cmd+Shift+T reopens things as the user closed them. In that way, it behaves like Undo (without the time bound nature).

• So, if one tab was recently closed, Ctrl/Cmd+Shift+T reopens that.
• If the last thing closed was a window from the current session, Ctrl/Cmd+Shift+T opens the window with whatever tabs were in it.
• If the last thing closed was from the previous session, and that thing was a window of multiple tabs, Ctrl/Cmd+Shift+T opens the window with whatever tabs were in it.

Comment 1

[Sarah Clements [:sclements]]

Attachment: Bug 1833416 - modify undoClosedTab keyboard shortcut r=mconley

• This patch expands this keyboard shortcut to support whichever of the three
  last actions were taken - last tab closed, last window closed or session restore.
• Existing test file was renamed and additional cases added.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a44656c2ad83
modify undoClosedTab keyboard shortcut r=mconley,sfoster,sessionstore-reviewers,dao

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a44656c2ad83

Comment 4

[tabmix.onemen]

After this bug landed, when Firefox is open Ctrl+Shift+T does not open closed tabs i have from last session

Step to reproduce:

1. set Firefox to 'Open previous windows and tabs'
2. on one open window open and close some tabs
3. close Firefox
4. open Firefox
5. click Ctrl+Shift+T to open last closed tab

Result: no tab open

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Thanks tabmix.onemen. I've filed that as bug 1838871.

Comment 6

[Sarah Clements [:sclements]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Changes existing behavior to the Command + shift + T keyboard shortcut.
[Affects Firefox for Android]: No
[Suggested wording]: The keyboard shortcut to reopen closed tabs (command + shift + t) now reopens last closed tab or last closed window, in the order items were closed. If there aren't any tabs or windows to reopen, this command restores the previous session. This change is in anticipation of upcoming changes to recently closed tabs.
[Links (documentation, blog post, etc)]: SUMO changes are tracked in bug 1841833.

Comment 7

[Dianna Smith [:diannaS]]

Relnote added to https://www.mozilla.org/en-US/firefox/116.0beta/releasenotes/

Comment 8

[tabmix.onemen]

There is one leftover key_undoCloseTab in RecentlyClosedTabsAndWindowsMenuUtils.sys.mjs createEntry function

  if (aIndex == 0) {
    element.setAttribute(
      "key",
      "key_undoClose" + (aIsWindowsFragment ? "Window" : "Tab")
    );
  }

Comment 9

[:Gijs (he/him)]

(In reply to tabmix.onemen from comment #8)

There is one leftover key_undoCloseTab in RecentlyClosedTabsAndWindowsMenuUtils.sys.mjs createEntry function

  if (aIndex == 0) {
    element.setAttribute(
      "key",
      "key_undoClose" + (aIsWindowsFragment ? "Window" : "Tab")
    );
  }

Fixed in bug 1868452.