1838968 - Create a special message action to open a sidebar

Status: RESOLVED WONTFIX

(Firefox :: Shopping, task, P2)

Description

[Shane Hughes [:aminomancer]]

Create a special message action to open a sidebar.
This action would allow us to open the shopping review check sidebar when a CTA is interacted with. It should allow specifying the first param for SidebarUI.show (the second probably won't be of much use for messaging) to configure which of the sidebar docs will open. That param is called commandID so the SMA definition could look something like this:

action: {
  type: "SHOW_SIDEBAR",
  data: {
    command_id: "viewBookmarksSidebar"
  }
}

Comment 1

[:Gijs (out for now; he/him)]

I'm confused about this bug. We won't be reusing the existing sidebar for the new experience, so I don't think things like "specify the first param for SidebarUI.show" make sense.

This bug should probably depend on a bug that implements the new shopping sidebar container in the first place.

Comment 2

[Shane Hughes [:aminomancer]]

(In reply to :Gijs (he/him) from comment #1)

I'm confused about this bug. We won't be reusing the existing sidebar for the new experience, so I don't think things like "specify the first param for SidebarUI.show" make sense.

This bug should probably depend on a bug that implements the new shopping sidebar container in the first place.

I was under the misapprehension that there would be a new sidebar using the existing system. We can close this or just update the bug when details for the new sidebar are available.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I'm pretty sure we either don't need this bug or it's a duplicate of some existing patch. Can we close it?

Comment 4

[Shane Hughes [:aminomancer]]

Yeah. Thanks for reminding me.