Closed Bug 1843436 Opened 1 year ago Closed 1 year ago

Add toggleSidebar method to ShoppingSidebarManager

Categories

(Firefox :: Shopping, task, P3)

task

Tracking

()

RESOLVED WONTFIX

People

(Reporter: jhirsch, Unassigned)

References

(Blocks 1 open bug)

Details

In bug 1842069, the OMC team is creating a special message action to allow the shopping sidebar to be closed if users opt out of the onboarding experience.

Let's expose a toggleSidebar() method on the ShoppingSidebarManager in browser/base/content/browser.js that this code can call, passing in an optional force argument to force the sidebar open (true) or shut (false).

Depends on: 1842069
Blocks: 1842069
No longer depends on: 1842069

Note--I think it may be good enough to listen for changes to the optIn pref value, rather than expose a function for the OMC code to call. That way, if the user opts out, we can close all the sidebars.

Another update - it seems like firing a signal from content to child actor might be the simplest way to consolidate both the onboarding "not now" button clicks and the settings component disable button clicks into a single code path. this might allow us to mark this bug as a dupe of bug 1843429.

See Also: → 1838968
Severity: -- → S3
Priority: -- → P3

Closing this in favor of the "Shopping:Close" CustomEvent fired within the page in bug 1845598, which toggles the browser.shopping.experience2023.active pref being added in bug 1840156.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.