1839158 - Crash - NumberFormatException in GeckoCreditCardsAddressesStorageDelegate

Status: VERIFIED FIXED

(Firefox for Android :: Autofill, defect)

Description

[Rahul Sainani [:rsainani]]

This crash has started occurring in 116 nightly.

Stack trace:

java.lang.NumberFormatException: For input string: ""
    at java.lang.Long.parseLong(Long.java:746)
    at java.lang.Long.parseLong(Long.java:861)
    at mozilla.components.service.sync.autofill.GeckoCreditCardsAddressesStorageDelegate$onCreditCardSave$2.invokeSuspend(GeckoCreditCardsAddressesStorageDelegate.kt:94)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:9)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:112)
    at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:4)
    at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:3)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:96)

Comment 2

[Roger Yang [:royang]]

Looks like this crash is on the rise https://mozilla.sentry.io/issues/4340986452/?project=6375561

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1839158 - Ignore invalid credit card save requests (#3052)

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1839158 - Swallow number format exceptions to prevent crash (#3059)

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1839158 - Ignore invalid credit card save requests (#3078)

Comment 6

[BMO Github Automation]

Authored by https://github.com/MatthewTighe
https://github.com/mozilla-mobile/firefox-android/commit/1b393daf9dd76e00e109eb60972cdb7b395cf254
[main] Bug 1839158 - Ignore invalid credit card save requests

Comment 7

[Delia Pop (Android QA)]

Hello, I verified this fix in the latest Nightly 118.0a1 from 08/02 with Samsung Galaxy A53 5G (Android 13), and the application remained stable while testing the Credit Card Autofill feature.
The following scenarios were covered during testing:

• attempt to save a new CC in the app menu, without one/all the following parameters: CC number, expiation month, expiration year;
• attempt to save a new CC while on the payment page without one/all the following parameters: CC number, expiation month, expiration year;
• autofill a payment form with a saved CC, then attempt to update the CC details without one/all the following parameters: CC number, expiation month, expiration year;

I'll mark this ticket as verified fixed.

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1839158 - Ignore invalid credit card save requests (backport #3078) (#3166)

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1839158 - Ignore invalid credit card save requests (backport #3078) (#3167)

Comment 10

[Matt Tighe [:matt-tighe]]

Comment on attachment 9346777 [details] [review]
[mozilla-mobile/firefox-android] Bug 1839158 - Ignore invalid credit card save requests (#3078)

Beta/Release Uplift Approval Request

• User impact if declined: High crash rate continues for workflows that involve credit card autofill
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch introduces a silent failure mechanism, so should not have any negative impact relative to existing behavior.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9348028 [details] [review]
[mozilla-mobile/firefox-android] Bug 1839158 - Ignore invalid credit card save requests (backport #3078) (#3166)

Approved for Mobile 117.0b5

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9348028 [details] [review]
[mozilla-mobile/firefox-android] Bug 1839158 - Ignore invalid credit card save requests (backport #3078) (#3166)

Fixing flags to corresponding release

Comment 13

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/a27decc2e8a9fa04ba8b224aba709f9e1356cf23
[releases_v117] Bug 1839158 - Ignore invalid credit card save requests (#3167)

Comment 14

[Andrei Mocirean]

Verified as fixed on Firefox Beta 117.0b5.
Devices used: Samsung Galaxy S22 Ultra (Android 13), Google Pixel 6 (Android 14), Sony Xperia (Android 6.0.1), Lenovo Yoga Tab 11 (Android 12) .

Comment 15

[Chris Peterson [:cpeterson]]

Matt, do you think your fix is safe enough to uplift to a 116 dot release? We already have a 116.0.3 dot release scheduled for next week (2023-08-14) so this fix could ride along.

Comment 16

[Matt Tighe [:matt-tighe]]

Yes, I think this fix could go out with the dot release. Will that be cut from a different branch than releases_v116? The backport to that branch has already been merged.

Comment 17

[Chris Peterson [:cpeterson]]

(In reply to Matt Tighe [:matt-tighe] from comment #16)

Yes, I think this fix could go out with the dot release. Will that be cut from a different branch than releases_v116? The backport to that branch has already been merged.

Sorry about that. I now see that you already requested uplift to 116 release (approval-mozilla-release?) in comment 10.

@ Dianna: you cleared the approval-mozilla-release? request for 116, but I don't see this bug fix in the releases_v116 branch's commit history. The most recent commit I see is asdf for bug 1847881:

https://github.com/mozilla-mobile/firefox-android/commits/releases_v116

Comment 18

[Dianna Smith [:diannaS]]

I will merge this closer to the v116 build but all I did was move the flag to the correct corresponding attachment. Ill prob be doing that in the next two days

Comment 19

[Dianna Smith [:diannaS]]

Comment on attachment 9348028 [details] [review]
[mozilla-mobile/firefox-android] Bug 1839158 - Ignore invalid credit card save requests (backport #3078) (#3166)

Approved for Mobile 116.3.0

Comment 20

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/0b51e0f371391dbddce196beef7a9a16dadf31f2
[releases_v116] Bug 1839158 - Ignore invalid credit card save requests (#3166)

Comment 21

[Adina Petridean QA [:apetridean]]

Verified as fixed on Firefox RC 116.3.0
Devices used: Huawei Mate 20 Lite(Android 10), Google Pixel 6 (Android 14), Samsung Galaxy Tab S3 (Android 9), Lenovo Yoga Tab 11 (Android 12) .