1839160 - Crash - NullPointerException in BookmarkFragment

Status: RESOLVED FIXED

(Firefox for Android :: Bookmarks, defect, P3)

Description

[Rahul Sainani [:rsainani]]

This crash has started occurring in 116 nightly.

Stack trace:

java.lang.NullPointerException: null
    at org.mozilla.fenix.library.bookmarks.BookmarkFragment.refreshBookmarks(BookmarkFragment.kt:103)
    at org.mozilla.fenix.library.bookmarks.BookmarkFragment$refreshBookmarks$1.invokeSuspend(BookmarkFragment.kt:14)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:9)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:112)
    at android.os.Handler.handleCallback(Handler.java:873)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:193)
    at android.app.ActivityThread.main(ActivityThread.java:6669)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Comment 1

[Mihai Adrian Carare [:mcarare]]

I managed to reproduce this crash (same stack trace) by rapidly clicking the bookmarks menu and opening 2 menus. Selecting one action ( delete) from the first and then using the second menu choosing a new option crashes the app.

This issue might come up in other screen that use the same menu, so the fix will involve preventing opening a menu twice.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1839160 - Prevent opening a menu twice. (#5920)

Comment 3

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/87c6fc31f96f93770c0e82cd12ad836bedb7443b
[main] Bug 1839160 - Prevent opening a menu twice.

Comment 4

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mcarare, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Mihai Adrian Carare [:mcarare]]

Relatively low volume, edge case STR. So holding off on an uplift.