1839226 - Replying with part of original message selected doesn't work correctly for plaintext messages which aren't format=flowed

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[better.bird.project+2]

+++ This bug was initially created as a clone of Bug #1818683 +++

Reply to the attached message with and without selection. This is a non-flowed message.

Comment 1

[better.bird.project+2]

Attachment: test-plain.eml

Comment 2

[better.bird.project+2]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1839226-fix-quoting-selection-non-flowed.patch

Comment 3

[[:Aureliano Buendía]]

I can confirm with attached testcase on TB 115.0b3 (64-bit):

If you reply without selecting part of the text everything is ok. If 2 lines are selected (e.g.: line 1 and line 2) the original formatting is lost and the 2 lines are put on a single new line: instead of as

line 1
line 2

is reported

line 1 line 2

Comment 4

[betterbird.project+9]

This seems to affect the extensions API as well. With add-on "Display Mail User Agent T" installed, replies to non f=f message are also incorrect. Our patch doesn't fix that (yet).

Comment 6

[Magnus Melin [:mkmelin]]

Turns out bug 267832 is a bit different. Especially wrt forwarding.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1839226 - Fix for replying to selection of original plaintext messages which isn't format=flowed. r=babolivier

Comment 8

[betterbird.project+11]

The patch doesn't work in the following case:
Have a HTML message with a plain text attachment and display this attachment inline, this needs setting pref mail.inline_attachments.text.
The result is that the selected HTML text is inserted into a <pre> since your query selector will find the div.moz-text-plain in the attachment display, but it's not the first <div> in the body which is the relevant <div>.
Please study
https://github.com/Betterbird/thunderbird-patches/blob/00d088d4351c39cf9e792341cfcf3542a3f37770/115/bugs/1839226-fix-quoting-selection-non-flowed.patch#L106

Can you fix this before it lands? We'd appreciate if you could attribute the basic idea to the fix accordingly. Yes, you shifted the implementation from JS to C++, but the concept is the same.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/db55005600e1
Fix for replying to selection of original plaintext messages which isn't format=flowed. r=babolivier

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9357613 [details]
Bug 1839226 - Fix for replying to selection of original plaintext messages which isn't format=flowed. r=babolivier

[Triage Comment]
Approved for beta

Comment 11

[Wayne Mery (:wsmwk)]

v.fixed on nightly

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 119.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/26cc9d66067b

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9357613 [details]
Bug 1839226 - Fix for replying to selection of original plaintext messages which isn't format=flowed. r=babolivier

[Triage Comment]
Approved for esr115

Comment 14

[Daniel Darnell [:dandarnell]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/2f302f74005f

Comment 15

[Magnus Melin [:mkmelin]]

Attachment: Bug_1839226___disable_browser_replySelection_js.diff

The test isn't working on 115. I don't see a direct reason for it and it's working just fine on trunk. Probably due to improvements in test infra elsewhere.
Tested manually and the feature itself seems to work just fine on 115, so I'm inclined to just disable the test for esr.

Comment 17

[Rob Lemley [:rjl]]

Comment on attachment 9359752 [details] [diff] [review]
Bug_1839226___disable_browser_replySelection_js.diff

[Triage Comment]
Approved.

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/e20fc26e16aa