1839304 - Investigate consecutive calls to setTree breaking the nodes parenting

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Marco Bonardo [:mak]]

While investigating Bug 1839066 Emilio found that nodes parenting gets broken after consecutive calls to setTree(null) and setTree(tree)
We should check what's up and add a test for that.

When this happens, various functions on the bookmarks may be broken.

Comment 2

[Marco Bonardo [:mak]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1865990#c7 for some example code to cause this.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1839304 - Don't disconnect Places result from the treeview on setTree(null). r=daisuke

SetTree(null) may be invoked in various cases where the view is temporarily
hidden, but not unloaded. the Places view should stop listening to changes only
when the document goes away, not when the tree is unset. In that case it should
be sufficient to close the root container to free up memory and avoid handling
notifications.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66c2fb78dfe2
Don't disconnect Places result from the treeview on setTree(null). r=daisuke,places-reviewers

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/66c2fb78dfe2